yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: unflake 'should not include trace resources from the previous chunks' test (#30257)

Browse Source
This commit is contained in:
Max Schmitt 2024-04-12 19:48:53 +02:00 committed by GitHub
parent 1ef85015f3
commit 56a7adeb8a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/playwright-core/src/client/browserContext.ts
View File

@ -432,6 +432,7 @@ export class BrowserContext extends ChannelOwner<channels.BrowserContextChannel>
this._browser._contexts.delete(this); this._browser._contexts.delete(this);
this._browserType?._contexts?.delete(this); this._browserType?._contexts?.delete(this);
this._disposeHarRouters(); this._disposeHarRouters();
this.tracing._resetStackCounter();
this.emit(Events.BrowserContext.Close, this); this.emit(Events.BrowserContext.Close, this);
} }

1
packages/playwright-core/src/client/fetch.ts
View File

@ -102,6 +102,7 @@ export class APIRequestContext extends ChannelOwner<channels.APIRequestContextCh
async dispose(): Promise<void> { async dispose(): Promise<void> {
await this._instrumentation.onWillCloseRequestContext(this); await this._instrumentation.onWillCloseRequestContext(this);
await this._channel.dispose(); await this._channel.dispose();
this._tracing._resetStackCounter();
this._request?._contexts.delete(this); this._request?._contexts.delete(this);
} }

12
packages/playwright-core/src/client/tracing.ts
View File

@ -76,10 +76,7 @@ export class Tracing extends ChannelOwner<channels.TracingChannel> implements ap
} }
private async _doStopChunk(filePath: string | undefined) { private async _doStopChunk(filePath: string | undefined) {
if (this._isTracing) { this._resetStackCounter();
this._isTracing = false;
this._connection.setIsTracing(false);
}
if (!filePath) { if (!filePath) {
// Not interested in artifacts. // Not interested in artifacts.
@ -113,4 +110,11 @@ export class Tracing extends ChannelOwner<channels.TracingChannel> implements ap
await this._connection.localUtils()._channel.zip({ zipFile: filePath, entries: [], mode: 'append', stacksId: this._stacksId, includeSources: this._includeSources }); await this._connection.localUtils()._channel.zip({ zipFile: filePath, entries: [], mode: 'append', stacksId: this._stacksId, includeSources: this._includeSources });
} }
_resetStackCounter() {
if (this._isTracing) {
this._isTracing = false;
this._connection.setIsTracing(false);
}
}
} }