yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(role): cache pseudo content calculation (#29115)

Browse Source
This commit is contained in:
Dmitry Gozman 2024-01-23 10:09:23 -08:00 committed by GitHub
parent 41c15cb176
commit 5bc5056a1f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
packages/playwright-core/src/server/injected/roleUtils.ts
View File

@ -323,7 +323,18 @@ function queryInAriaOwned(element: Element, selector: string): Element[] {
return result; return result;
} }
function getPseudoContent(pseudoStyle: CSSStyleDeclaration | undefined) { function getPseudoContent(element: Element, pseudo: '::before' | '::after') {
const cache = pseudo === '::before' ? cachePseudoContentBefore : cachePseudoContentAfter;
if (cache?.has(element))
return cache?.get(element) || '';
const pseudoStyle = getElementComputedStyle(element, pseudo);
const content = getPseudoContentImpl(pseudoStyle);
if (cache)
cache.set(element, content);
return content;
}
function getPseudoContentImpl(pseudoStyle: CSSStyleDeclaration | undefined) {
if (!pseudoStyle) if (!pseudoStyle)
return ''; return '';
const content = pseudoStyle.content; const content = pseudoStyle.content;
@ -677,7 +688,7 @@ function getElementAccessibleNameInternal(element: Element, options: AccessibleN
tokens.push(node.textContent || ''); tokens.push(node.textContent || '');
} }
}; };
tokens.push(getPseudoContent(getElementComputedStyle(element, '::before'))); tokens.push(getPseudoContent(element, '::before'));
const assignedNodes = element.nodeName === 'SLOT' ? (element as HTMLSlotElement).assignedNodes() : []; const assignedNodes = element.nodeName === 'SLOT' ? (element as HTMLSlotElement).assignedNodes() : [];
if (assignedNodes.length) { if (assignedNodes.length) {
for (const child of assignedNodes) for (const child of assignedNodes)
@ -692,7 +703,7 @@ function getElementAccessibleNameInternal(element: Element, options: AccessibleN
for (const owned of getIdRefs(element, element.getAttribute('aria-owns'))) for (const owned of getIdRefs(element, element.getAttribute('aria-owns')))
visit(owned, true); visit(owned, true);
} }
tokens.push(getPseudoContent(getElementComputedStyle(element, '::after'))); tokens.push(getPseudoContent(element, '::after'));
const accessibleName = tokens.join(''); const accessibleName = tokens.join('');
if (accessibleName.trim()) if (accessibleName.trim())
return accessibleName; return accessibleName;
@ -837,6 +848,8 @@ function getAccessibleNameFromAssociatedLabels(labels: Iterable<HTMLLabelElement
let cacheAccessibleName: Map<Element, string> | undefined; let cacheAccessibleName: Map<Element, string> | undefined;
let cacheAccessibleNameHidden: Map<Element, string> | undefined; let cacheAccessibleNameHidden: Map<Element, string> | undefined;
let cacheIsHidden: Map<Element, boolean> | undefined; let cacheIsHidden: Map<Element, boolean> | undefined;
let cachePseudoContentBefore: Map<Element, string> | undefined;
let cachePseudoContentAfter: Map<Element, string> | undefined;
let cachesCounter = 0; let cachesCounter = 0;
export function beginAriaCaches() { export function beginAriaCaches() {
@ -844,6 +857,8 @@ export function beginAriaCaches() {
cacheAccessibleName ??= new Map(); cacheAccessibleName ??= new Map();
cacheAccessibleNameHidden ??= new Map(); cacheAccessibleNameHidden ??= new Map();
cacheIsHidden ??= new Map(); cacheIsHidden ??= new Map();
cachePseudoContentBefore ??= new Map();
cachePseudoContentAfter ??= new Map();
} }
export function endAriaCaches() { export function endAriaCaches() {
@ -851,5 +866,7 @@ export function endAriaCaches() {
cacheAccessibleName = undefined; cacheAccessibleName = undefined;
cacheAccessibleNameHidden = undefined; cacheAccessibleNameHidden = undefined;
cacheIsHidden = undefined; cacheIsHidden = undefined;
cachePseudoContentBefore = undefined;
cachePseudoContentAfter = undefined;
} }
} }