yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(codegen): missing await before newPage.goto (#6253)

Browse Source
This commit is contained in:
Dmitry Gozman 2021-04-21 07:59:38 -07:00 committed by GitHub
parent 85e2db2416
commit 640b10c70f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/server/supplements/recorder/csharp.ts
View File

@ -35,7 +35,7 @@ export class CSharpLanguageGenerator implements LanguageGenerator {
if (action.name === 'openPage') { if (action.name === 'openPage') {
formatter.add(`var ${pageAlias} = await context.NewPageAsync();`); formatter.add(`var ${pageAlias} = await context.NewPageAsync();`);
if (action.url && action.url !== 'about:blank' && action.url !== 'chrome://newtab/') if (action.url && action.url !== 'about:blank' && action.url !== 'chrome://newtab/')
formatter.add(`${pageAlias}.GoToAsync('${action.url}');`); formatter.add(`await ${pageAlias}.GoToAsync(${quote(action.url)});`);
return formatter.format(); return formatter.format();
} }

2
src/server/supplements/recorder/javascript.ts
View File

@ -35,7 +35,7 @@ export class JavaScriptLanguageGenerator implements LanguageGenerator {
if (action.name === 'openPage') { if (action.name === 'openPage') {
formatter.add(`const ${pageAlias} = await context.newPage();`); formatter.add(`const ${pageAlias} = await context.newPage();`);
if (action.url && action.url !== 'about:blank' && action.url !== 'chrome://newtab/') if (action.url && action.url !== 'about:blank' && action.url !== 'chrome://newtab/')
formatter.add(`${pageAlias}.goto('${action.url}');`); formatter.add(`await ${pageAlias}.goto(${quote(action.url)});`);
return formatter.format(); return formatter.format();
} }

2
src/server/supplements/recorder/python.ts
View File

@ -47,7 +47,7 @@ export class PythonLanguageGenerator implements LanguageGenerator {
if (action.name === 'openPage') { if (action.name === 'openPage') {
formatter.add(`${pageAlias} = ${this._awaitPrefix}context.new_page()`); formatter.add(`${pageAlias} = ${this._awaitPrefix}context.new_page()`);
if (action.url && action.url !== 'about:blank' && action.url !== 'chrome://newtab/') if (action.url && action.url !== 'about:blank' && action.url !== 'chrome://newtab/')
formatter.add(`${pageAlias}.goto('${action.url}')`); formatter.add(`${this._awaitPrefix}${pageAlias}.goto(${quote(action.url)})`);
return formatter.format(); return formatter.format();
} }

10
tests/cli/cli-codegen-2.spec.ts
View File

@ -376,7 +376,15 @@ await page.ClickAsync(\"text=click me\");`);
expect(sources.get('<javascript>').text).toContain(` expect(sources.get('<javascript>').text).toContain(`
// Open new page // Open new page
const page1 = await context.newPage(); const page1 = await context.newPage();
page1.goto('about:blank?foo');`); await page1.goto('about:blank?foo');`);
expect(sources.get('<async python>').text).toContain(`
# Open new page
page1 = await context.new_page()
await page1.goto("about:blank?foo")`);
expect(sources.get('<csharp>').text).toContain(`
// Open new page
var page1 = await context.NewPageAsync();
await page1.GoToAsync("about:blank?foo");`);
} else if (browserName === 'firefox') { } else if (browserName === 'firefox') {
expect(sources.get('<javascript>').text).toContain(` expect(sources.get('<javascript>').text).toContain(`
// Click text=link // Click text=link