yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(build): fix MaxListenersExceededWarning during build (#35905)

Browse Source
This commit is contained in:
Max Schmitt 2025-05-09 17:01:03 +02:00 committed by GitHub
parent d3a67559e8
commit 64c553bb71
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
utils/build/build.js
View File

@ -57,6 +57,8 @@ const { build, context } = require('esbuild');
* @typedef {CommandOnChange|ScriptOnChange} OnChange
*/
/** @type {(() => void)[]} */
const disposables = [];
/** @type {Step[]} */
const steps = [];
/** @type {OnChange[]} */
@ -130,7 +132,10 @@ class ProgramStep extends Step {
},
cwd: step.cwd,
});
process.on('exit', () => child.kill());
disposables.push(() => {
if (child.exitCode === null)
child.kill();
});
return new Promise((resolve, reject) => {
child.on('close', (code, signal) => {
if (code || signal)
@ -299,6 +304,7 @@ class EsbuildStep extends Step {
if (this._context)
return;
this._context = await context(this._options);
disposables.push(() => this._context?.dispose());
const watcher = chokidar.watch(this._options.entryPoints);
await new Promise(x => watcher.once('ready', x));
@ -540,4 +546,20 @@ if (lintMode) {
}
}
let cleanupCalled = false;
function cleanup() {
if (cleanupCalled)
return;
cleanupCalled = true;
for (const disposable of disposables) {
try {
disposable();
} catch (e) {
console.error('Error during cleanup:', e);
}
}
}
process.on('exit', cleanup);
process.on('SIGINT', cleanup);
watchMode ? runWatch() : runBuild();