From 64cd55089ab8d6b33eae2c8346c4d3a0c4224010 Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Sun, 8 May 2022 11:07:01 +0100
Subject: [PATCH] chore: role selectors non-experimental (#14021)

---
 packages/playwright-core/src/server/selectors.ts | 2 +-
 tests/page/selectors-role.spec.ts                | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/packages/playwright-core/src/server/selectors.ts b/packages/playwright-core/src/server/selectors.ts
index 78bb4e5434..611edc6490 100644
--- a/packages/playwright-core/src/server/selectors.ts
+++ b/packages/playwright-core/src/server/selectors.ts
@@ -47,6 +47,7 @@ export class Selectors {
       'data-test', 'data-test:light',
       'nth', 'visible', 'control', 'has',
       'left-of', 'right-of', 'above', 'below', 'near',
+      'role',
     ]);
     this._builtinEnginesInMainWorld = new Set([
       '_react', '_vue',
@@ -135,7 +136,6 @@ export class Selectors {
   }
 
   parseSelector(selector: string | ParsedSelector, strict: boolean): SelectorInfo {
-    this._builtinEngines.add('role');
     const parsed = typeof selector === 'string' ? parseSelector(selector) : selector;
     let needsMainWorld = false;
     for (const name of allEngineNames(parsed)) {
diff --git a/tests/page/selectors-role.spec.ts b/tests/page/selectors-role.spec.ts
index 95f6dcfc0f..4b024d466d 100644
--- a/tests/page/selectors-role.spec.ts
+++ b/tests/page/selectors-role.spec.ts
@@ -16,8 +16,6 @@
 
 import { test, expect } from './pageTest';
 
-test.skip(({ mode }) => mode !== 'default', 'Experimental features only work in default mode');
-
 test('should detect roles', async ({ page }) => {
   await page.setContent(`
     <button>Hello</button>