From 6512bccffdb451228361fd8ddfdb1ae1d499cbf3 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Wed, 21 Aug 2024 11:37:53 +0200 Subject: [PATCH] docs(best-practises): add note about tsc (#32245) --- docs/src/best-practices-js.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/best-practices-js.md b/docs/src/best-practices-js.md index 7d4830b6cb..3b70817923 100644 --- a/docs/src/best-practices-js.md +++ b/docs/src/best-practices-js.md @@ -265,7 +265,7 @@ Use Linux when running your tests on CI as it is cheaper. Developers can use wha ### Lint your tests -Linting the tests helps catching errors early. Use [`@typescript-eslint/no-floating-promises`](https://typescript-eslint.io/rules/no-floating-promises/) [ESLint](https://eslint.org) rule to make sure there are no missing awaits before the asynchronous calls to the Playwright API. +We recommend TypeScript and linting with ESLint for your tests to catch errors early. Use [`@typescript-eslint/no-floating-promises`](https://typescript-eslint.io/rules/no-floating-promises/) [ESLint](https://eslint.org) rule to make sure there are no missing awaits before the asynchronous calls to the Playwright API. On your CI you can run `tsc --noEmit` to ensure that functions are called with the right signature. ### Use parallelism and sharding