yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: re-implement slow-mo transport without message serialization (#1328)

Browse Source 
With this implementation, `slowMo` will throttle all `outbound`
messages.

Fixes #1214
This commit is contained in:
Andrey Lushnikov 2020-03-10 15:57:39 -07:00 committed by GitHub
parent a24cce8b74
commit 65d10a5d5d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/transport.ts
View File

@ -25,8 +25,6 @@ export interface ConnectionTransport {
export class SlowMoTransport { export class SlowMoTransport {
private readonly _delay: number; private readonly _delay: number;
private readonly _delegate: ConnectionTransport; private readonly _delegate: ConnectionTransport;
private _incomingMessageQueue: string[] = [];
private _dispatchTimerId?: NodeJS.Timer;
onmessage?: (message: string) => void; onmessage?: (message: string) => void;
onclose?: () => void; onclose?: () => void;
@ -38,34 +36,13 @@ export class SlowMoTransport {
constructor(transport: ConnectionTransport, delay: number) { constructor(transport: ConnectionTransport, delay: number) {
this._delay = delay; this._delay = delay;
this._delegate = transport; this._delegate = transport;
this._delegate.onmessage = this._enqueueMessage.bind(this); this._delegate.onmessage = this._onmessage.bind(this);
this._delegate.onclose = this._onClose.bind(this); this._delegate.onclose = this._onClose.bind(this);
} }
private _enqueueMessage(message: string) { private _onmessage(message: string) {
this._incomingMessageQueue.push(message);
this._scheduleQueueDispatch();
}
private _scheduleQueueDispatch() {
if (this._dispatchTimerId)
return;
if (!this._incomingMessageQueue.length)
return;
this._dispatchTimerId = setTimeout(() => {
this._dispatchTimerId = undefined;
this._dispatchOneMessageFromQueue();
}, this._delay);
}
private _dispatchOneMessageFromQueue() {
const message = this._incomingMessageQueue.shift();
try {
if (this.onmessage) if (this.onmessage)
this.onmessage(message!); this.onmessage(message);
} finally {
this._scheduleQueueDispatch();
}
} }
private _onClose() { private _onClose() {
@ -76,7 +53,10 @@ export class SlowMoTransport {
} }
send(s: string) { send(s: string) {
setTimeout(() => {
if (this._delegate.onmessage)
this._delegate.send(s); this._delegate.send(s);
}, this._delay);
} }
close() { close() {