From 6cf70e2e4cad9901b13719f8ef8dbaf7de8041e6 Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Fri, 17 Jan 2020 17:51:48 -0800
Subject: [PATCH] test(firefox): enable some passing tests (#536)

---
 test/click.spec.js      | 2 +-
 test/evaluation.spec.js | 4 ++--
 test/page.spec.js       | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/test/click.spec.js b/test/click.spec.js
index b2d19118cf..39325b4876 100644
--- a/test/click.spec.js
+++ b/test/click.spec.js
@@ -78,7 +78,7 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI
       await page.click('button');
       expect(await page.evaluate(() => result)).toBe('Clicked');
     });
-    it.skip(FFOX)('should click with disabled javascript', async({newPage, server}) => {
+    it('should click with disabled javascript', async({newPage, server}) => {
       const page = await newPage({ javaScriptEnabled: false });
       await page.goto(server.PREFIX + '/wrappedlink.html');
       await Promise.all([
diff --git a/test/evaluation.spec.js b/test/evaluation.spec.js
index 4da4f02e41..cba1938ddd 100644
--- a/test/evaluation.spec.js
+++ b/test/evaluation.spec.js
@@ -247,7 +247,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT})
       const error = await errorPromise;
       expect(error.message).toContain('navigation');
     });
-    it.skip(FFOX)('should not throw an error when evaluation does a navigation', async({page, server}) => {
+    it('should not throw an error when evaluation does a navigation', async({page, server}) => {
       await page.goto(server.PREFIX + '/one-style.html');
       const result = await page.evaluate(() => {
         window.location = '/empty.html';
@@ -354,7 +354,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT})
       const result = await childFrame.evaluate(foo => foo.bar, handle);
       expect(result).toBe('baz');
     });
-    it.skip(FFOX)('should allow cross-frame element handles', async({page, server}) => {
+    it('should allow cross-frame element handles', async({page, server}) => {
       await page.goto(server.PREFIX + '/frames/one-frame.html');
       const bodyHandle = await page.mainFrame().childFrames()[0].$('body');
       const result = await page.evaluate(body => body.innerHTML, bodyHandle);
diff --git a/test/page.spec.js b/test/page.spec.js
index afb4ef7408..a8cf9e0786 100644
--- a/test/page.spec.js
+++ b/test/page.spec.js
@@ -855,7 +855,7 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF
       expect(await page.evaluate(() => result.onInput)).toEqual(['blue']);
       expect(await page.evaluate(() => result.onChange)).toEqual(['blue']);
     });
-    it.skip(FFOX)('should not throw when select causes navigation', async({page, server}) => { await page.goto(server.PREFIX + '/input/select.html');
+    it('should not throw when select causes navigation', async({page, server}) => { await page.goto(server.PREFIX + '/input/select.html');
       await page.$eval('select', select => select.addEventListener('input', () => window.location = '/empty.html'));
       await Promise.all([
         page.select('select', 'blue'),