From 6d51ed6e4dee59f67b0f4160f535775efeae114b Mon Sep 17 00:00:00 2001
From: Yury Semikhatsky <yurys@chromium.org>
Date: Mon, 30 Aug 2021 13:41:25 -0700
Subject: [PATCH] feat(fetch): support baseURL, add tests for invalid args
 (#8562)

---
 src/server/fetch.ts                |  3 +--
 tests/browsercontext-fetch.spec.ts | 41 ++++++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 2 deletions(-)

diff --git a/src/server/fetch.ts b/src/server/fetch.ts
index 5027641cab..e3b84a8e2b 100644
--- a/src/server/fetch.ts
+++ b/src/server/fetch.ts
@@ -47,8 +47,7 @@ export async function playwrightFetch(context: BrowserContext, params: types.Fet
       agent = new HttpsProxyAgent(proxyOpts);
     }
 
-    // TODO(https://github.com/microsoft/playwright/issues/8381): set user agent
-    const fetchResponse = await sendRequest(context, new URL(params.url), {
+    const fetchResponse = await sendRequest(context, new URL(params.url, context._options.baseURL), {
       method,
       headers,
       agent,
diff --git a/tests/browsercontext-fetch.spec.ts b/tests/browsercontext-fetch.spec.ts
index d0d67a6ace..a321cd32c9 100644
--- a/tests/browsercontext-fetch.spec.ts
+++ b/tests/browsercontext-fetch.spec.ts
@@ -349,3 +349,44 @@ it('should propagate extra http headers with redirects', async ({context, server
   expect(req3.headers['my-secret']).toBe('Value');
 });
 
+it('should throw on invalid header value', async ({context, server}) => {
+  // @ts-expect-error
+  const error = await context._fetch(`${server.PREFIX}/a/redirect1`, {
+    headers: {
+      'foo': 'недопустимое значение',
+    }
+  }).catch(e => e);
+  expect(error.message).toContain('Invalid character in header content');
+});
+
+it('should throw on non-http(s) protocol', async ({context}) => {
+  // @ts-expect-error
+  const error1 = await context._fetch(`data:text/plain,test`).catch(e => e);
+  expect(error1.message).toContain('Protocol "data:" not supported');
+  // @ts-expect-error
+  const error2 = await context._fetch(`file:///tmp/foo`).catch(e => e);
+  expect(error2.message).toContain('Protocol "file:" not supported');
+});
+
+it('should support https', async ({context, httpsServer}) => {
+  const oldValue = process.env['NODE_TLS_REJECT_UNAUTHORIZED'];
+  // https://stackoverflow.com/a/21961005/552185
+  process.env['NODE_TLS_REJECT_UNAUTHORIZED'] = '0';
+  try {
+    // @ts-expect-error
+    const response = await context._fetch(httpsServer.EMPTY_PAGE);
+    expect(response.status()).toBe(200);
+  } finally {
+    process.env['NODE_TLS_REJECT_UNAUTHORIZED'] = oldValue;
+  }
+});
+
+it('should resolve url relative to baseURL', async function({browser, server, contextFactory, contextOptions}) {
+  const context = await contextFactory({
+    ...contextOptions,
+    baseURL: server.PREFIX,
+  });
+  // @ts-expect-error
+  const response = await context._fetch('/empty.html');
+  expect(response.url()).toBe(server.EMPTY_PAGE);
+});