yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(launcher): extend list of known missing DLLs (#3256)

Browse Source 
#2745
This commit is contained in:
Yury Semikhatsky 2020-07-31 14:11:11 -07:00 committed by GitHub
parent 8709ad7bf1
commit 7e8d03b050
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/server/validateDependencies.ts
View File

@ -65,9 +65,9 @@ async function validateDependenciesWindows(browserPath: string, browser: Browser
let isCrtMissing = false; let isCrtMissing = false;
let isMediaFoundationMissing = false; let isMediaFoundationMissing = false;
for (const dep of missingDeps) { for (const dep of missingDeps) {
if (dep.startsWith('api-ms-win-crt')) if (dep.startsWith('api-ms-win-crt') || dep === 'vcruntime140.dll' || dep === 'msvcp140.dll')
isCrtMissing = true; isCrtMissing = true;
else if (dep === 'mf.dll' || dep === 'mfplat.dll' || dep === 'msmpeg2vdec.dll') else if (dep === 'mf.dll' || dep === 'mfplat.dll' || dep === 'msmpeg2vdec.dll' || dep === 'evr.dll' || dep === 'avrt.dll')
isMediaFoundationMissing = true; isMediaFoundationMissing = true;
} }
@ -211,7 +211,7 @@ async function missingFileDependencies(filePath: string): Promise<Array<string>>
}); });
if (code !== 0) if (code !== 0)
return []; return [];
const missingDeps = stdout.split('\n').map(line => line.trim()).filter(line => line.endsWith('not found') && line.includes('=>')).map(line => line.split('=>')[0].trim()); const missingDeps = stdout.split('\n').map(line => line.trim()).filter(line => line.endsWith('not found') && line.includes('=>')).map(line => line.split('=>')[0].trim().toLowerCase());
return missingDeps; return missingDeps;
} }