From 807f70bccf975a007f68a3faf7e4a949d58b1ab7 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Tue, 11 Jan 2022 17:12:18 -0800 Subject: [PATCH] fix(electron): remove timeout from electronApp.close (#11336) We do not have a timeout for any other close method, such as browserContext.close or browser.close, and hitting default 30 seconds is very realistic with large Electron apps. --- packages/playwright-core/src/server/electron/electron.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/playwright-core/src/server/electron/electron.ts b/packages/playwright-core/src/server/electron/electron.ts index dd6ae8271c..39bd42fd6d 100644 --- a/packages/playwright-core/src/server/electron/electron.ts +++ b/packages/playwright-core/src/server/electron/electron.ts @@ -83,7 +83,7 @@ export class ElectronApplication extends SdkObject { async close() { const progressController = new ProgressController(internalCallMetadata(), this); - const closed = progressController.run(progress => helper.waitForEvent(progress, this, ElectronApplication.Events.Close).promise, this._timeoutSettings.timeout({})); + const closed = progressController.run(progress => helper.waitForEvent(progress, this, ElectronApplication.Events.Close).promise); await this._browserContext.close(internalCallMetadata()); this._nodeConnection.close(); await closed;