yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(electron/android): re-add Element.prototype.checkVisibility check (#28173)

Browse Source 
Regressed in https://github.com/microsoft/playwright/pull/28148.
This commit is contained in:
Max Schmitt 2023-11-16 00:10:13 +01:00 committed by GitHub
parent 7ffcb42551
commit 80bab8afae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/playwright-core/src/server/injected/domUtils.ts
View File

@ -82,7 +82,8 @@ export function isElementStyleVisibilityVisible(element: Element, style?: CSSSty
// details element for example. // details element for example.
// All the browser implement it, but WebKit has a bug which prevents us from using it: // All the browser implement it, but WebKit has a bug which prevents us from using it:
// https://bugs.webkit.org/show_bug.cgi?id=264733 // https://bugs.webkit.org/show_bug.cgi?id=264733
if (browserNameForWorkarounds !== 'webkit') { // @ts-ignore
if (Element.prototype.checkVisibility && browserNameForWorkarounds !== 'webkit') {
if (!element.checkVisibility({ checkOpacity: false, checkVisibilityCSS: false })) if (!element.checkVisibility({ checkOpacity: false, checkVisibilityCSS: false }))
return false; return false;
} else { } else {