From 84a0aaaaff813f8d48dc597dea97742304be3e3d Mon Sep 17 00:00:00 2001 From: Playwright Service <89237858+playwrightmachine@users.noreply.github.com> Date: Mon, 5 Dec 2022 11:22:03 -0800 Subject: [PATCH] feat(chromium-tip-of-tree): roll to r1065 (#19239) Signed-off-by: Max Schmitt Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Max Schmitt --- packages/playwright-core/browsers.json | 4 ++-- tests/library/chromium/css-coverage.spec.ts | 15 +++++++++------ 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json index eff3f75ae5..16533f4a2e 100644 --- a/packages/playwright-core/browsers.json +++ b/packages/playwright-core/browsers.json @@ -15,9 +15,9 @@ }, { "name": "chromium-tip-of-tree", - "revision": "1063", + "revision": "1065", "installByDefault": false, - "browserVersion": "110.0.5435.0" + "browserVersion": "110.0.5451.0" }, { "name": "firefox", diff --git a/tests/library/chromium/css-coverage.spec.ts b/tests/library/chromium/css-coverage.spec.ts index bb385caa6f..cf1c9c9c67 100644 --- a/tests/library/chromium/css-coverage.spec.ts +++ b/tests/library/chromium/css-coverage.spec.ts @@ -14,6 +14,7 @@ * limitations under the License. */ +import { chromiumVersionLessThan } from '../../config/utils'; import { contextTest as it, expect } from '../../config/browserTest'; it('should work', async function({ page, server }) { @@ -56,21 +57,23 @@ it('should report stylesheets that have no coverage', async function({ page, ser expect(coverage[0].ranges.length).toBe(0); }); -it('should work with media queries', async function({ page, server }) { +it('should work with media queries', async function({ page, server, browserVersion }) { + it.skip(chromiumVersionLessThan(browserVersion, '110.0.5451.0'), 'https://chromium-review.googlesource.com/c/chromium/src/+/4051280'); await page.coverage.startCSSCoverage(); await page.goto(server.PREFIX + '/csscoverage/media.html'); const coverage = await page.coverage.stopCSSCoverage(); expect(coverage.length).toBe(1); expect(coverage[0].url).toContain('/csscoverage/media.html'); expect(coverage[0].ranges).toEqual([ - { start: 17, end: 38 } + { start: 8, end: 40 } ]); }); -it('should work with complicated usecases', async function({ page, server }) { +it('should work with complicated usecases', async function({ page, server, browserVersion }) { + it.skip(chromiumVersionLessThan(browserVersion, '110.0.5451.0'), 'https://chromium-review.googlesource.com/c/chromium/src/+/4051280'); await page.coverage.startCSSCoverage(); await page.goto(server.PREFIX + '/csscoverage/involved.html'); - const coverage: any = await page.coverage.stopCSSCoverage(); + const coverage = await page.coverage.stopCSSCoverage(); delete coverage[0].text; delete coverage[0].url; expect(coverage).toEqual( @@ -82,8 +85,8 @@ it('should work with complicated usecases', async function({ page, server }) { 'end': 297 }, { - 'start': 327, - 'end': 433 + 'start': 306, + 'end': 435 } ] }