mirror of
				https://github.com/microsoft/playwright.git
				synced 2025-06-26 21:40:17 +00:00 
			
		
		
		
	devops: do not use broken overwrite: true for uploads (#29160)
Reverting parts of https://github.com/microsoft/playwright/pull/29080 related to use of overwrite: true as it is racy and [fails](https://github.com/microsoft/playwright/actions/runs/7641699534/job/20819588957?pr=28932#step:10:63) time to time with parallel jobs:  Reference https://github.com/actions/upload-artifact/issues/506
This commit is contained in:
		
							parent
							
								
									4c4789c740
								
							
						
					
					
						commit
						85c42939b1
					
				@ -29,6 +29,5 @@ runs:
 | 
			
		||||
      if: always() && github.event_name == 'pull_request'
 | 
			
		||||
      uses: actions/upload-artifact@v4
 | 
			
		||||
      with:
 | 
			
		||||
        name: pull-request-number
 | 
			
		||||
        path: pull_request_number.txt
 | 
			
		||||
        overwrite: true
 | 
			
		||||
        name: pull-request-${{ inputs.job_name }}
 | 
			
		||||
        path: pull_request_number.txt
 | 
			
		||||
							
								
								
									
										2
									
								
								.github/workflows/create_test_report.yml
									
									
									
									
										vendored
									
									
								
							
							
						
						
									
										2
									
								
								.github/workflows/create_test_report.yml
									
									
									
									
										vendored
									
									
								
							@ -49,7 +49,7 @@ jobs:
 | 
			
		||||
    - name: Read pull request number
 | 
			
		||||
      uses: ./.github/actions/download-artifact
 | 
			
		||||
      with:
 | 
			
		||||
        namePrefix: 'pull-request-number'
 | 
			
		||||
        namePrefix: 'pull-request'
 | 
			
		||||
        path: '.'
 | 
			
		||||
 | 
			
		||||
    - name: Comment on PR
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user