chore: allow click close the page w/o errors (#27994)

packages/playwright-core/src/server/dispatchers/artifactDispatcher.ts

@@ -107,7 +107,7 @@ export class ArtifactDispatcher extends Dispatcher<Artifact, channels.ArtifactCh
   }
 
   async delete(_: any, metadata: CallMetadata): Promise<void> {
-    metadata.closesScope = true;
+    metadata.potentiallyClosesScope = true;
     await this._object.delete();
     this._dispose();
   }

packages/playwright-core/src/server/dispatchers/browserContextDispatcher.ts

@@ -273,7 +273,7 @@ export class BrowserContextDispatcher extends Dispatcher<BrowserContext, channel
   }
 
   async close(params: channels.BrowserContextCloseParams, metadata: CallMetadata): Promise<void> {
-    metadata.closesScope = true;
+    metadata.potentiallyClosesScope = true;
     await this._context.close(params);
   }
 

packages/playwright-core/src/server/dispatchers/browserDispatcher.ts

@@ -56,12 +56,12 @@ export class BrowserDispatcher extends Dispatcher<Browser, channels.BrowserChann
   }
 
   async close(params: channels.BrowserCloseParams, metadata: CallMetadata): Promise<void> {
-    metadata.closesScope = true;
+    metadata.potentiallyClosesScope = true;
     await this._object.close(params);
   }
 
   async killForTests(_: any, metadata: CallMetadata): Promise<void> {
-    metadata.closesScope = true;
+    metadata.potentiallyClosesScope = true;
     await this._object.killForTests();
   }
 

packages/playwright-core/src/server/dispatchers/cdpSessionDispatcher.ts

@@ -35,7 +35,7 @@ export class CDPSessionDispatcher extends Dispatcher<CDPSession, channels.CDPSes
   }
 
   async detach(_: any, metadata: CallMetadata): Promise<void> {
-    metadata.closesScope = true;
+    metadata.potentiallyClosesScope = true;
     await this._object.detach();
   }
 }

packages/playwright-core/src/server/dispatchers/dispatcher.ts

@@ -99,7 +99,7 @@ export class Dispatcher<Type extends { guid: string }, ChannelType, ParentScopeT
     try {
       return await this._openScope.race(commandPromise);
     } catch (e) {
-      if (callMetadata.closesScope && isTargetClosedError(e))
+      if (callMetadata.potentiallyClosesScope && isTargetClosedError(e))
         return await commandPromise;
       throw e;
     }

packages/playwright-core/src/server/dispatchers/frameDispatcher.ts

@@ -133,6 +133,7 @@ export class FrameDispatcher extends Dispatcher<Frame, channels.FrameChannel, Br
   }
 
   async click(params: channels.FrameClickParams, metadata: CallMetadata): Promise<void> {
+    metadata.potentiallyClosesScope = true;
     return await this._frame.click(metadata, params.selector, params);
   }
 
@@ -265,7 +266,7 @@ export class FrameDispatcher extends Dispatcher<Frame, channels.FrameChannel, Br
   }
 
   async expect(params: channels.FrameExpectParams, metadata: CallMetadata): Promise<channels.FrameExpectResult> {
-    metadata.closesScope = true;
+    metadata.potentiallyClosesScope = true;
     const expectedValue = params.expectedValue ? parseArgument(params.expectedValue) : undefined;
     const result = await this._frame.expect(metadata, params.selector, { ...params, expectedValue });
     if (result.received !== undefined)

packages/playwright-core/src/server/dispatchers/jsHandleDispatcher.ts

@@ -68,7 +68,7 @@ export class JSHandleDispatcher extends Dispatcher<js.JSHandle, channels.JSHandl
   }
 
   async dispose(_: any, metadata: CallMetadata) {
-    metadata.closesScope = true;
+    metadata.potentiallyClosesScope = true;
     this._object.dispose();
     this._dispose();
   }

packages/playwright-core/src/server/dispatchers/networkDispatchers.ts

@@ -199,7 +199,7 @@ export class APIRequestContextDispatcher extends Dispatcher<APIRequestContext, c
   }
 
   async dispose(_: channels.APIRequestContextDisposeParams, metadata: CallMetadata): Promise<void> {
-    metadata.closesScope = true;
+    metadata.potentiallyClosesScope = true;
     await this._object.dispose();
     this._dispose();
   }

packages/playwright-core/src/server/dispatchers/pageDispatcher.ts

@@ -201,7 +201,7 @@ export class PageDispatcher extends Dispatcher<Page, channels.PageChannel, Brows
 
   async close(params: channels.PageCloseParams, metadata: CallMetadata): Promise<void> {
     if (!params.runBeforeUnload)
-      metadata.closesScope = true;
+      metadata.potentiallyClosesScope = true;
     await this._page.close(metadata, params);
   }
 

packages/protocol/src/callMetadata.ts

@@ -42,5 +42,5 @@ export type CallMetadata = {
   objectId?: string;
   pageId?: string;
   frameId?: string;
-  closesScope?: boolean;
+  potentiallyClosesScope?: boolean;
 };

tests/library/popup.spec.ts

@@ -261,6 +261,19 @@ it('should not throttle rAF in the opener page', async ({ page, server }) => {
   ]);
 });
 
+it('should not throw when click closes popup', async ({ browserName, page, server }) => {
+  it.fixme(browserName === 'firefox');
+  await page.goto(server.EMPTY_PAGE);
+  const [popup] = await Promise.all([
+    page.waitForEvent('popup'),
+    page.evaluate(() => {
+      const w = window.open('about:blank');
+      w.document.body.innerHTML = `<button onclick="window.close()">close</button>`;
+    }),
+  ]);
+  await popup.getByRole('button').click();
+});
+
 async function waitForRafs(page: Page, count: number): Promise<void> {
   await page.evaluate(count => new Promise<void>(resolve => {
     const onRaf = () => {