yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

devops: stop using MacOS 10.12 SDK when building Firefox (#9452)

Browse Source 
An investigation has shown, that:
- Official Firefox builds actually cross-compile from Linux to MacOS,
  and for this reason use the old MacOS 10.12 SDK.
- We should be able to build with 11+ SDK just fine; read [primer on
  MacOS SDKs] for details.
- A random `symbol '___darwin_check_fd_set_overflow' not supported`
  error seems to be an [apple bug]. We can fix it using
  `LDFLAGS="-Wl,-U,___darwin_check_fd_set_overflow"`
  flag, similarly to [haskell compiler fix].

[primer on MacOS SDKs]: https://firefox-source-docs.mozilla.org/widget/cocoa/sdks.html
[apple bug]: https://openradar.appspot.com/FB7647406
[haskell compiler fix]: 7745638702
This commit is contained in:
Andrey Lushnikov 2021-10-12 13:23:43 -07:00 committed by GitHub
parent 34e933f474
commit 87f120fa35
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
browser_patches/firefox-beta/build.sh
View File

@ -33,22 +33,6 @@ if [[ "$(uname)" == "Darwin" ]]; then
echo "ERROR: ${CURRENT_HOST_OS_VERSION} is not supported"
exit 1
fi
# Firefox on Mac Intel requires SDK for 10.12 to work on old versions of MacOS.
# Mac on Apple Silicon doesn't exist on old versions of MacOS, so this is not needed.
if [[ "$(uname -m)" == "x86_64" ]]; then
if ! [[ -d $HOME/SDK-archive/MacOSX${MACOS_SDK_VERSION}.sdk ]]; then
echo "As of Dec 2020, Firefox does not build on Mac ${CURRENT_HOST_OS_VERSION} without ${MACOS_SDK_VERSION} SDK."
echo "Download XCode ${XCODE_VERSION_WITH_REQUIRED_SDK_VERSION} from https://developer.apple.com/download/more/ and"
echo "extract SDK to $HOME/SDK-archive/MacOSX${MACOS_SDK_VERSION}.sdk"
echo ""
echo "More info: https://firefox-source-docs.mozilla.org/setup/macos_build.html"
exit 1
else
echo "-- configuting .mozconfig with ${MACOS_SDK_VERSION} SDK path"
echo "ac_add_options --with-macos-sdk=$HOME/SDK-archive/MacOSX${MACOS_SDK_VERSION}.sdk/" >> .mozconfig
fi
fi
echo "-- building on Mac"
elif [[ "$(uname)" == "Linux" ]]; then
echo "-- building on Linux"