From 89aa02228fe76429a8b0e4e9db807b6958f4e600 Mon Sep 17 00:00:00 2001
From: Max Schmitt <max@schmitt.mx>
Date: Wed, 17 May 2023 01:13:09 +0200
Subject: [PATCH] devops: add macOS 13 coverage (#23065)

Coverage https://github.com/microsoft/playwright/issues/22226
---
 .github/workflows/tests_secondary.yml |  2 +-
 tests/library/signals.spec.ts         | 10 +++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/tests_secondary.yml b/.github/workflows/tests_secondary.yml
index 3945629bd5..47722a880f 100644
--- a/.github/workflows/tests_secondary.yml
+++ b/.github/workflows/tests_secondary.yml
@@ -57,7 +57,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [macos-11, macos-12]
+        os: [macos-12, macos-13]
         browser: [chromium, firefox, webkit]
     runs-on: ${{ matrix.os }}
     steps:
diff --git a/tests/library/signals.spec.ts b/tests/library/signals.spec.ts
index 8a684543b3..f4ccef8187 100644
--- a/tests/library/signals.spec.ts
+++ b/tests/library/signals.spec.ts
@@ -18,6 +18,7 @@
 import { playwrightTest as test, expect } from '../config/browserTest';
 import { execSync } from 'child_process';
 import fs from 'fs';
+import os from 'os';
 
 test.slow();
 
@@ -56,7 +57,8 @@ test('should remove temp dir on process.exit', async ({ startRemoteServer, serve
 test.describe('signals', () => {
   test.skip(({ platform }) => platform === 'win32');
 
-  test('should report browser close signal 2', async ({ startRemoteServer, server }) => {
+  test('should report browser close signal 2', async ({ startRemoteServer, server, isMac, browserName }) => {
+    test.fixme(isMac && browserName === 'webkit' && parseInt(os.release(), 10) >= 22, 'https://github.com/microsoft/playwright/issues/22226');
     const remoteServer = await startRemoteServer('launchServer', { url: server.EMPTY_PAGE });
     const pid = await remoteServer.out('pid');
     process.kill(-pid, 'SIGKILL');
@@ -90,7 +92,8 @@ test.describe('signals', () => {
     expect(await remoteServer.childExitCode()).toBe(0);
   });
 
-  test('should kill the browser on double SIGINT and remove temp dir', async ({ startRemoteServer, server }) => {
+  test('should kill the browser on double SIGINT and remove temp dir', async ({ startRemoteServer, server, isMac, browserName }) => {
+    test.fixme(isMac && browserName === 'webkit' && parseInt(os.release(), 10) >= 22, 'https://github.com/microsoft/playwright/issues/22226');
     const remoteServer = await startRemoteServer('launchServer', { stallOnClose: true, url: server.EMPTY_PAGE });
     const tempDir = await remoteServer.out('tempDir');
     const before = fs.existsSync(tempDir);
@@ -105,7 +108,8 @@ test.describe('signals', () => {
     expect(after).toBe(false);
   });
 
-  test('should kill the browser on SIGINT + SIGTERM', async ({ startRemoteServer, server }) => {
+  test('should kill the browser on SIGINT + SIGTERM', async ({ startRemoteServer, server, isMac, browserName }) => {
+    test.fixme(isMac && browserName === 'webkit' && parseInt(os.release(), 10) >= 22, 'https://github.com/microsoft/playwright/issues/22226');
     const remoteServer = await startRemoteServer('launchServer', { stallOnClose: true, url: server.EMPTY_PAGE });
     process.kill(remoteServer.child().pid, 'SIGINT');
     await remoteServer.out('stalled');