From 89b8fdd4e570c1e1de5e4e0ccfe8b82cca59775e Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Thu, 21 Apr 2022 14:40:30 -0800 Subject: [PATCH] fix(tracing): do not reset frame counter on every chunk (#13689) --- packages/playwright-core/src/server/trace/recorder/tracing.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/playwright-core/src/server/trace/recorder/tracing.ts b/packages/playwright-core/src/server/trace/recorder/tracing.ts index dc7effa5dc..223fbe9b27 100644 --- a/packages/playwright-core/src/server/trace/recorder/tracing.ts +++ b/packages/playwright-core/src/server/trace/recorder/tracing.ts @@ -391,10 +391,9 @@ export class Tracing extends SdkObject implements InstrumentationListener, Snaps private _startScreencastInPage(page: Page) { page.setScreencastOptions(kScreencastOptions); const prefix = page.guid; - let frameSeq = 0; this._screencastListeners.push( eventsHelper.addEventListener(page, Page.Events.ScreencastFrame, params => { - const suffix = String(++frameSeq).padStart(10, '0'); + const suffix = params.timestamp || Date.now(); const sha1 = `${prefix}-${suffix}.jpeg`; const event: trace.ScreencastFrameTraceEvent = { type: 'screencast-frame',