From 8b18722181c1a46ffd77460f171571b61fc743b9 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Thu, 3 Aug 2023 15:34:23 -0700 Subject: [PATCH] chore: drop run_attempt from github artifact name (#24594) --- .github/actions/upload-blob-report/action.yml | 2 +- .github/workflows/create_test_report.yml | 6 +++--- docs/src/test-sharding-js.md | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/actions/upload-blob-report/action.yml b/.github/actions/upload-blob-report/action.yml index 6fd17587db..284d7820f6 100644 --- a/.github/actions/upload-blob-report/action.yml +++ b/.github/actions/upload-blob-report/action.yml @@ -23,7 +23,7 @@ runs: if: always() && github.event_name == 'pull_request' uses: actions/upload-artifact@v3 with: - name: blob-report-${{ github.run_attempt }} + name: all-blob-reports path: ${{ inputs.report_dir }} retention-days: 30 - name: Write triggering pull request number in a file diff --git a/.github/workflows/create_test_report.yml b/.github/workflows/create_test_report.yml index 84ef24fc91..bc3f74aa31 100644 --- a/.github/workflows/create_test_report.yml +++ b/.github/workflows/create_test_report.yml @@ -26,12 +26,12 @@ jobs: - name: Download blob report artifact uses: ./.github/actions/download-artifact with: - name: 'blob-report-${{ github.event.workflow_run.run_attempt }}' - path: 'blob-report' + name: all-blob-reports + path: all-blob-reports - name: Merge reports run: | - npx playwright merge-reports --reporter markdown,html ./blob-report + npx playwright merge-reports --reporter markdown,html ./all-blob-reports - name: Upload HTML report to Azure run: | diff --git a/docs/src/test-sharding-js.md b/docs/src/test-sharding-js.md index ef06a942b6..04b9bd74e6 100644 --- a/docs/src/test-sharding-js.md +++ b/docs/src/test-sharding-js.md @@ -33,7 +33,7 @@ export default defineConfig({ Blob report contains information about all the tests that were run and their results as well as all test attachments such as traces and screenshot diffs. Blob reports can be merged and converted to any other Playwright report. By default, blob report will be generated into `blob-report` directory. -To merge reports from multiple shards, put the blob report files into a single directory, for example `all-blob-reports`. Blob reports are generated with unique names, so they will not clash. +To merge reports from multiple shards, put the blob report files into a single directory, for example `all-blob-reports`. Blob report names contain shard number, so they will not clash. Afterwards, run `npx playwright merge-reports` command: @@ -77,7 +77,7 @@ jobs: if: always() uses: actions/upload-artifact@v3 with: - name: all-blob-reports--attempt-${{ github.run_attempt }} + name: all-blob-reports path: blob-report retention-days: 1 ``` @@ -102,7 +102,7 @@ jobs: - name: Download blob reports from GitHub Actions Artifacts uses: actions/download-artifact@v3 with: - name: all-blob-reports--attempt-${{ github.run_attempt }} + name: all-blob-reports path: all-blob-reports - name: Merge into HTML Report