From 8c40b920c9a54d41ece6a27f9bbe2536e0d4cbee Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Wed, 15 Apr 2020 11:42:45 -0700 Subject: [PATCH] fix: set non-0 exit code for install scripts if there are problems (#1739) Fixes #1731 --- download-browser.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/download-browser.js b/download-browser.js index 1a0679e71e..53eabe29b3 100644 --- a/download-browser.js +++ b/download-browser.js @@ -62,7 +62,10 @@ async function downloadBrowserWithProgressBar(options) { lastDownloadedBytes = downloadedBytes; progressBar.tick(delta); } - await browserFetcher.downloadBrowser({...options, progress}); + await browserFetcher.downloadBrowser({...options, progress}).catch(e => { + process.exitCode = 1; + throw e; + }); logPolitely(`${options.progressBarBrowserName} downloaded to ${options.downloadPath}`); }