yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(fixtures): do not force-close contexts in beforeAll (#12416)

Browse Source 
This now happens the same way as for the test, in the worker cleanup
when browser closes, which is reported as a part of the test.
This commit is contained in:
Dmitry Gozman 2022-03-09 07:26:46 -08:00 committed by GitHub
parent e8ce5d0258
commit 92430cc56c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/playwright-test/src/index.ts
View File

@ -421,15 +421,6 @@ export const test = _baseTest.extend<TestFixtures, WorkerFixtures>({
else else
await fs.promises.unlink(file).catch(() => {}); await fs.promises.unlink(file).catch(() => {});
})); }));
// 7. Cleanup created contexts when we know it's safe - this will produce nice error message.
if (testInfo.status === 'timedOut' && testInfo.errors.some(error => error.message?.match(/Timeout of \d+ms exceeded in beforeAll hook./))) {
const anyContext = leftoverContexts[0];
const pendingCalls = anyContext ? formatPendingCalls((anyContext as any)._connection.pendingProtocolCalls()) : '';
await Promise.all(leftoverContexts.filter(c => createdContexts.has(c)).map(c => c.close()));
if (pendingCalls)
testInfo.errors.push({ message: pendingCalls });
}
}, { auto: true }], }, { auto: true }],
_contextFactory: async ({ browser, video, _artifactsDir }, use, testInfo) => { _contextFactory: async ({ browser, video, _artifactsDir }, use, testInfo) => {

5
tests/playwright-test/playwright.spec.ts
View File

@ -353,7 +353,7 @@ test('should report error on timeout with shared page', async ({ runInlineTest }
expect(stripAnsi(result.output)).toContain(`14 | await page.click('text=Missing');`); expect(stripAnsi(result.output)).toContain(`14 | await page.click('text=Missing');`);
}); });
test('should report error and pending operations from beforeAll timeout', async ({ runInlineTest }, testInfo) => { test('should report error from beforeAll timeout', async ({ runInlineTest }, testInfo) => {
const result = await runInlineTest({ const result = await runInlineTest({
'a.test.ts': ` 'a.test.ts': `
const { test } = pwt; const { test } = pwt;
@ -373,9 +373,6 @@ test('should report error and pending operations from beforeAll timeout', async
expect(result.passed).toBe(0); expect(result.passed).toBe(0);
expect(result.failed).toBe(1); expect(result.failed).toBe(1);
expect(result.output).toContain('Timeout of 2000ms exceeded in beforeAll hook.'); expect(result.output).toContain('Timeout of 2000ms exceeded in beforeAll hook.');
expect(result.output).toContain('Pending operations:');
expect(result.output).toContain('- page.click at a.test.ts:10:16');
expect(result.output).toContain('- page.textContent at a.test.ts:11:16');
expect(result.output).toContain('waiting for selector'); expect(result.output).toContain('waiting for selector');
expect(stripAnsi(result.output)).toContain(`11 | page.textContent('text=More missing'),`); expect(stripAnsi(result.output)).toContain(`11 | page.textContent('text=More missing'),`);
}); });