yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: skip test when run with PWTEST_TRACING (#11999)

Browse Source 
This test tries to enable tracing itself; double-enabling
tracing throws an error.

This started failing after 284f76357f
This commit is contained in:
Andrey Lushnikov 2022-02-10 10:45:18 -07:00 committed by GitHub
parent 1df07aa2cf
commit 9287ef2dfb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/browsertype-connect.spec.ts
View File

@ -532,7 +532,8 @@ test('should save har', async ({ browserType, startRemoteServer, server }, testI
expect(entry.request.url).toBe(server.EMPTY_PAGE);
});
test('should record trace with sources', async ({ browserType, startRemoteServer, server }, testInfo) => {
test('should record trace with sources', async ({ browserType, startRemoteServer, server, trace }, testInfo) => {
test.skip(trace === 'on');
const remoteServer = await startRemoteServer();
const browser = await browserType.connect(remoteServer.wsEndpoint());
const context = await browser.newContext();

28
tests/video.spec.ts
View File

@ -159,8 +159,8 @@ it.describe('screencast', () => {
expect(error.message).toContain('"videoSize" option requires "videosPath" to be specified');
});
it('should work with old options', async ({ browser, browserName }, testInfo) => {
it.fixme(browserName === 'firefox' && !!process.env.PWTEST_TRACE, 'https://github.com/microsoft/playwright/issues/10060');
it('should work with old options', async ({ browser, browserName, trace }, testInfo) => {
it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060');
const videosPath = testInfo.outputPath('');
const size = { width: 450, height: 240 };
const context = await browser.newContext({
@ -183,8 +183,8 @@ it.describe('screencast', () => {
expect(error.message).toContain('recordVideo.dir: expected string, got undefined');
});
it('should capture static page', async ({ browser, browserName }, testInfo) => {
it.fixme(browserName === 'firefox' && !!process.env.PWTEST_TRACE, 'https://github.com/microsoft/playwright/issues/10060');
it('should capture static page', async ({ browser, browserName, trace }, testInfo) => {
it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060');
const size = { width: 450, height: 240 };
const context = await browser.newContext({
recordVideo: {
@ -309,8 +309,8 @@ it.describe('screencast', () => {
expect(fs.existsSync(path)).toBeTruthy();
});
it('should capture navigation', async ({ browser, browserName, server }, testInfo) => {
it.fixme(browserName === 'firefox' && !!process.env.PWTEST_TRACE, 'https://github.com/microsoft/playwright/issues/10060');
it('should capture navigation', async ({ browser, browserName, server, trace }, testInfo) => {
it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060');
const context = await browser.newContext({
recordVideo: {
dir: testInfo.outputPath(''),
@ -341,10 +341,10 @@ it.describe('screencast', () => {
}
});
it('should capture css transformation', async ({ browser, server, headless, browserName, platform }, testInfo) => {
it('should capture css transformation', async ({ browser, server, headless, browserName, platform, trace }, testInfo) => {
it.fixme(!headless, 'Fails on headed');
it.fixme(browserName === 'webkit' && platform === 'win32');
it.fixme(browserName === 'firefox' && !!process.env.PWTEST_TRACE, 'https://github.com/microsoft/playwright/issues/10060');
it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060');
const size = { width: 320, height: 240 };
// Set viewport equal to screencast frame size to avoid scaling.
@ -372,8 +372,8 @@ it.describe('screencast', () => {
}
});
it('should work for popups', async ({ browser, server, browserName }, testInfo) => {
it.fixme(browserName === 'firefox' && !!process.env.PWTEST_TRACE, 'https://github.com/microsoft/playwright/issues/10060');
it('should work for popups', async ({ browser, server, browserName, trace }, testInfo) => {
it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060');
const videosPath = testInfo.outputPath('');
const size = { width: 450, height: 240 };
const context = await browser.newContext({
@ -403,9 +403,9 @@ it.describe('screencast', () => {
expect(videoFiles.length).toBe(2);
});
it('should scale frames down to the requested size ', async ({ browser, browserName, server, headless }, testInfo) => {
it('should scale frames down to the requested size ', async ({ browser, browserName, server, headless, trace }, testInfo) => {
it.fixme(!headless, 'Fails on headed');
it.fixme(browserName === 'firefox' && !!process.env.PWTEST_TRACE, 'https://github.com/microsoft/playwright/issues/10060');
it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060');
const context = await browser.newContext({
recordVideo: {
@ -508,8 +508,8 @@ it.describe('screencast', () => {
expect(videoPlayer.videoHeight).toBe(600);
});
it('should capture static page in persistent context #smoke', async ({ launchPersistent, browserName }, testInfo) => {
it.fixme(browserName === 'firefox' && !!process.env.PWTEST_TRACE, 'https://github.com/microsoft/playwright/issues/10060');
it('should capture static page in persistent context #smoke', async ({ launchPersistent, browserName, trace }, testInfo) => {
it.fixme(browserName === 'firefox' && trace === 'on', 'https://github.com/microsoft/playwright/issues/10060');
const size = { width: 320, height: 240 };
const { context, page } = await launchPersistent({
recordVideo: {