yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(playwright-test): scan the world (#6935)

Browse Source 
Running `npx playwright test` results in a cryptic error message that says to check `--help` for more information.

I started to rewrite it, but I think instead it would be much nicer if we just treated `npx playwright test` as an alias for `npx playwright test -c .`. There is a comment in the code that worries this will be slow because it will scan the world. However we need to support this case anyway for the tests-next-to-code pattern.

It looks like this should be fast because we ignore node_modules/.gitignore entries. If this is still too slow we should make it faster. If we can't make it faster we should throw a more specific error telling the user how to make it faster.
This commit is contained in:
Joel Einbinder 2021-06-08 11:02:16 -07:00 committed by GitHub
parent 53d68bdb38
commit 93f6b57ca5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/cli.ts
View File

@ -122,8 +122,8 @@ async function runTests(args: string[], opts: { [key: string]: any }) {
} }
} else if (!loadConfig(path.resolve(process.cwd(), tsConfig)) && !loadConfig(path.resolve(process.cwd(), jsConfig))) { } else if (!loadConfig(path.resolve(process.cwd(), tsConfig)) && !loadConfig(path.resolve(process.cwd(), jsConfig))) {
// No --config option, let's look for the config file in the current directory. // No --config option, let's look for the config file in the current directory.
// If not, do not assume that current directory is a root testing directory, to avoid scanning the world. // If not, scan the world.
throw new Error(`Configuration file not found. Run "npx playwright test --help" for more information.`); runner.loadEmptyConfig(process.cwd());
} }
const result = await runner.run(!!opts.list, args.map(forceRegExp), opts.project || undefined); const result = await runner.run(!!opts.list, args.map(forceRegExp), opts.project || undefined);