From 94e272ba0f1d1718f14cbaedc48eb62b5337a84d Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Mon, 18 Sep 2023 17:01:19 -0700 Subject: [PATCH] fix(firefox): properly handle navigations (#27132) In firefox, the `frameRequestedNavigation` is coming from renderer and thus can happen **after** the `Network.requestWillBeSent`, which is dispatched from the browser process. Fixes https://github.com/microsoft/playwright/issues/24132 --- packages/playwright-core/src/server/frames.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/playwright-core/src/server/frames.ts b/packages/playwright-core/src/server/frames.ts index 271f3ff99d..1fed89ab69 100644 --- a/packages/playwright-core/src/server/frames.ts +++ b/packages/playwright-core/src/server/frames.ts @@ -200,7 +200,9 @@ export class FrameManager { // Do not override request with undefined. return; } - frame.setPendingDocument({ documentId, request: undefined }); + + const request = documentId ? Array.from(frame._inflightRequests).find(request => request._documentId === documentId) : undefined; + frame.setPendingDocument({ documentId, request }); } frameCommittedNewDocumentNavigation(frameId: string, url: string, name: string, documentId: string, initial: boolean) {