From 96945ab0a2c5a75ccdad3a2dd6ff7a3bfc08cc33 Mon Sep 17 00:00:00 2001
From: Pavel Feldman <pavel.feldman@gmail.com>
Date: Tue, 1 Mar 2022 09:11:53 -0800
Subject: [PATCH] chore: do not print empty attachments in terminal (#12419)

---
 packages/playwright-test/src/reporters/base.ts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/packages/playwright-test/src/reporters/base.ts b/packages/playwright-test/src/reporters/base.ts
index 12c4d24910..cf6b38793e 100644
--- a/packages/playwright-test/src/reporters/base.ts
+++ b/packages/playwright-test/src/reporters/base.ts
@@ -250,6 +250,9 @@ export function formatFailure(config: FullConfig, test: TestCase, options: {inde
     if (includeAttachments) {
       for (let i = 0; i < result.attachments.length; ++i) {
         const attachment = result.attachments[i];
+        const hasPrintableContent = attachment.contentType.startsWith('text/') && attachment.body;
+        if (!attachment.path && !hasPrintableContent)
+          continue;
         resultLines.push('');
         resultLines.push(colors.cyan(pad(`    attachment #${i + 1}: ${attachment.name} (${attachment.contentType})`, '-')));
         if (attachment.path) {