diff --git a/test/browser.spec.js b/test/browser.spec.js index 0c7c97405c..ddce2b9492 100644 --- a/test/browser.spec.js +++ b/test/browser.spec.js @@ -22,13 +22,13 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; describe('Browser', function() { - it('should create new page', async function({browser}) { + it('should create new page', async function({browser, newPage}) { expect((await browser.pages()).length).toBe(0); - const page1 = await browser.newPage(); + const page1 = await newPage(); expect((await browser.pages()).length).toBe(1); expect(browser.browserContexts().length).toBe(1); - const page2 = await browser.newPage(); + const page2 = await newPage(); expect((await browser.pages()).length).toBe(2); expect(browser.browserContexts().length).toBe(2); diff --git a/test/chromium/chromium.spec.js b/test/chromium/chromium.spec.js index 991ae284b6..5e27ffe4b6 100644 --- a/test/chromium/chromium.spec.js +++ b/test/chromium/chromium.spec.js @@ -189,7 +189,7 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI await page.goto(server.EMPTY_PAGE); const target = await targetPromise; expect(await target.page()).toBe(page); - await page.close(); + await page.browserContext().close(); }); it('should fire target events', async function({browser, newContext, server}) { const context = await newContext(); diff --git a/test/chromium/tracing.spec.js b/test/chromium/tracing.spec.js index c593d20455..13ac0e01e3 100644 --- a/test/chromium/tracing.spec.js +++ b/test/chromium/tracing.spec.js @@ -55,7 +55,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p const newPage = await browser.newPage(); let error = null; await browser.startTracing(newPage, {path: outputFile}).catch(e => error = e); - await newPage.close(); + await newPage.browserContext().close(); expect(error).toBeTruthy(); await browser.stopTracing(); }); diff --git a/test/web.spec.js b/test/web.spec.js index 1d5eed646d..9a52997d08 100644 --- a/test/web.spec.js +++ b/test/web.spec.js @@ -43,7 +43,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p afterEach(async state => { await state.page.evaluate(() => teardown()); - await state.page.close(); + await state.page.browserContext().close(); state.page = null; }); diff --git a/utils/protocol-types-generator/index.js b/utils/protocol-types-generator/index.js index 5ca9ce37b4..1b9ee382c6 100644 --- a/utils/protocol-types-generator/index.js +++ b/utils/protocol-types-generator/index.js @@ -16,7 +16,7 @@ async function generateChromiunProtocol(revision) { const page = await browser.newPage(); await page.goto(`http://${origin}/json/protocol`); const json = JSON.parse(await page.evaluate(() => document.documentElement.innerText)); - await browserServer.kill(); + await browserServer.close(); fs.writeFileSync(outputPath, jsonToTS(json)); console.log(`Wrote protocol.ts to ${path.relative(process.cwd(), outputPath)}`); }