yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(ct): throw error when props are not json serializable (#22025)

Browse Source
This commit is contained in:
Sander 2023-03-29 22:59:27 +02:00 committed by GitHub
parent 8b7dc2cf7a
commit 9c0c5d6e2a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
packages/playwright-test/src/mount.ts
View File

@ -51,6 +51,8 @@ export const fixtures: Fixtures<
mount: async ({ page }, use) => { mount: async ({ page }, use) => {
await use(async (component: JsxComponent | string, options?: MountOptions) => { await use(async (component: JsxComponent | string, options?: MountOptions) => {
if (options?.props && !isJson(options.props))
throw new Error('The mount function props are not JSON serializable.');
const selector = await (page as any)._wrapApiCall(async () => { const selector = await (page as any)._wrapApiCall(async () => {
return await innerMount(page, component, options); return await innerMount(page, component, options);
}, true); }, true);
@ -63,7 +65,10 @@ export const fixtures: Fixtures<
}); });
}, },
update: async (options: JsxComponent | Omit<MountOptions, 'hooksConfig'>) => { update: async (options: JsxComponent | Omit<MountOptions, 'hooksConfig'>) => {
if (isJsxApi(options)) return await innerUpdate(page, options); if (isJsxApi(options))
return await innerUpdate(page, options);
if (options?.props && !isJson(options.props))
throw new Error('The update function props are not JSON serializable.');
await innerUpdate(page, component, options); await innerUpdate(page, component, options);
} }
}); });
@ -72,6 +77,24 @@ export const fixtures: Fixtures<
}, },
}; };
const jsonType: Record<string, Function> = {
string: (value: any) => typeof value === 'string',
number: (value: any) => typeof value === 'number',
boolean: (value: any) => typeof value === 'boolean',
null: (value: any) => value === null,
array: (value: any) => Array.isArray(value) && value.every(isJson),
object: (value: any) => typeof value === 'object' && value !== null && !Array.isArray(value)
&& Object.values(value).every(isJson),
};
function isJson(value: any): boolean {
const valueType = Array.isArray(value) ? 'array' : typeof value;
const validate = jsonType[valueType];
if (validate)
return validate(value);
return false;
}
function isJsxApi(options: Record<string, unknown>): options is JsxComponent { function isJsxApi(options: Record<string, unknown>): options is JsxComponent {
return options?.kind === 'jsx'; return options?.kind === 'jsx';
} }