yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: poll test result along with the live trace (#22714)

Browse Source 
Fixes: https://github.com/microsoft/playwright/issues/22656
This commit is contained in:
Pavel Feldman 2023-04-28 16:56:28 -07:00 committed by GitHub
parent ffc00566b9
commit 9c29f24c65
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/trace-viewer/src/ui/uiModeView.tsx
View File

@ -483,10 +483,9 @@ const TraceView: React.FC<{
const [counter, setCounter] = React.useState(0); const [counter, setCounter] = React.useState(0);
const pollTimer = React.useRef<NodeJS.Timeout | null>(null); const pollTimer = React.useRef<NodeJS.Timeout | null>(null);
const { outputDir, result } = React.useMemo(() => { const { outputDir } = React.useMemo(() => {
const outputDir = item.testCase ? outputDirForTestCase(item.testCase) : undefined; const outputDir = item.testCase ? outputDirForTestCase(item.testCase) : undefined;
const result = item.testCase?.results[0]; return { outputDir };
return { outputDir, result };
}, [item]); }, [item]);
// Preserve user selection upon live-reloading trace model by persisting the action id. // Preserve user selection upon live-reloading trace model by persisting the action id.
@ -499,6 +498,7 @@ const TraceView: React.FC<{
if (pollTimer.current) if (pollTimer.current)
clearTimeout(pollTimer.current); clearTimeout(pollTimer.current);
const result = item.testCase?.results[0];
if (!result) { if (!result) {
setModel(undefined); setModel(undefined);
return; return;
@ -532,7 +532,7 @@ const TraceView: React.FC<{
if (pollTimer.current) if (pollTimer.current)
clearTimeout(pollTimer.current); clearTimeout(pollTimer.current);
}; };
}, [result, outputDir, item, setModel, counter, setCounter]); }, [outputDir, item, setModel, counter, setCounter]);
return <Workbench return <Workbench
key='workbench' key='workbench'