yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(dupe): render dupe test error indicator (#32303)

Browse Source 
Fixes https://github.com/microsoft/playwright/issues/32093
This commit is contained in:
Pavel Feldman 2024-08-23 14:33:37 -07:00 committed by GitHub
parent 37eb66df10
commit 9d86bc5336
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 37 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/trace-viewer/src/ui/workbench.tsx
View File

@ -83,7 +83,7 @@ export const Workbench: React.FunctionComponent<{
setRevealedStack(action?.stack);
}, [setSelectedActionImpl, setRevealedStack]);
const sources = React.useMemo(() => model?.sources || new Map(), [model]);
const sources = React.useMemo(() => model?.sources || new Map<string, modelUtil.SourceModel>(), [model]);
React.useEffect(() => {
setSelectedTime(undefined);
@ -179,9 +179,17 @@ export const Workbench: React.FunctionComponent<{
selectPropertiesTab('source');
}} />
};
// Fallback location w/o action stands for file / test.
// Render error count on Source tab for that case.
let fallbackSourceErrorCount: number | undefined = undefined;
if (!selectedAction && fallbackLocation)
fallbackSourceErrorCount = fallbackLocation.source?.errors.length;
const sourceTab: TabbedPaneTabModel = {
id: 'source',
title: 'Source',
errorCount: fallbackSourceErrorCount,
render: () => <SourceTab
stack={revealedStack}
sources={sources}

28
tests/playwright-test/ui-mode-test-source.spec.ts
View File

@ -128,3 +128,31 @@ test('should show syntax errors in file', async ({ runUITest }) => {
/Missing semicolon./
]);
});
test('should load error (dupe tests) indicator on sources', async ({ runUITest }) => {
const { page } = await runUITest({
'a.test.ts': `
import { test } from '@playwright/test';
test('first', () => {});
test('first', () => {});
`,
});
await expect.poll(dumpTestTree(page)).toBe(`
▼ ◯ a.test.ts
◯ first
`);
await page.getByTestId('test-tree').getByText('a.test.ts').click();
await expect(page.getByText('Source1')).toBeVisible();
await expect(
page.locator('.CodeMirror .source-line-running'),
).toHaveText(`4 test('first', () => {});`);
await expect(
page.locator('.CodeMirror-linewidget')
).toHaveText([
'                              ',
/Error: duplicate test title "first", first declared in a.test.ts:3/
]);
});