chore(test): use pathToFileURL (#3292)

This commit is contained in:
Yury Semikhatsky 2020-08-04 17:26:42 -07:00 committed by GitHub
parent 3c2fcb7fe4
commit 9ec026730f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 13 deletions

View File

@ -15,6 +15,7 @@
*/
const path = require('path');
const url = require('url');
const {FFOX, CHROMIUM, WEBKIT, WIN, LINUX, ASSETS_DIR} = testOptions;
@ -58,10 +59,7 @@ it.fail(WEBKIT && WIN)('should play video', async({page}) => {
const absolutePath = path.join(ASSETS_DIR, fileName);
// Our test server doesn't support range requests required to play on Mac,
// so we load the page using a file url.
const url = WIN
? 'file:///' + absolutePath.replace(/\\/g, '/')
: 'file://' + absolutePath;
await page.goto(url);
await page.goto(url.pathToFileURL(absolutePath).href);
await page.$eval('video', v => v.play());
await page.$eval('video', v => v.pause());
});

View File

@ -15,11 +15,6 @@
* limitations under the License.
*/
const utils = require('./utils');
const path = require('path');
const url = require('url');
const {FFOX, CHROMIUM, WEBKIT, ASSETS_DIR, MAC, WIN} = testOptions;
it('should work with _blank target', async({page, server}) => {
server.setRoute('/empty.html', (req, res) => {
res.end(`<a href="${server.EMPTY_PAGE}" target="_blank">Click me</a>`);

View File

@ -15,7 +15,6 @@
* limitations under the License.
*/
const utils = require('./utils');
const path = require('path');
const url = require('url');
const {FFOX, CHROMIUM, WEBKIT, ASSETS_DIR, MAC, WIN} = testOptions;
@ -56,9 +55,7 @@ it('page.goBack should work with HistoryAPI', async({page, server}) => {
it.fail(WEBKIT && MAC)('page.goBack should work for file urls', async ({page, server}) => {
// WebKit embedder fails to go back/forward to the file url.
const url1 = WIN
? 'file:///' + path.join(ASSETS_DIR, 'empty.html').replace(/\\/g, '/')
: 'file://' + path.join(ASSETS_DIR, 'empty.html');
const url1 = url.pathToFileURL(path.join(ASSETS_DIR, 'empty.html')).href;
const url2 = server.EMPTY_PAGE;
await page.goto(url1);
await page.setContent(`<a href='${url2}'>url2</a>`);