From a1b3332e54e52b68f4b184162a01df85ee2a0d0e Mon Sep 17 00:00:00 2001
From: Max Schmitt <max@schmitt.mx>
Date: Fri, 19 Apr 2024 00:34:07 +0200
Subject: [PATCH] chore: follow-up on Electron launch (#30423)

Follow-up to https://github.com/microsoft/playwright/pull/30382.
---
 packages/playwright-core/src/server/electron/electron.ts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/packages/playwright-core/src/server/electron/electron.ts b/packages/playwright-core/src/server/electron/electron.ts
index f6de5058d8..c55257510c 100644
--- a/packages/playwright-core/src/server/electron/electron.ts
+++ b/packages/playwright-core/src/server/electron/electron.ts
@@ -208,7 +208,9 @@ export class Electron extends SdkObject {
           progress.log(message);
           browserLogsCollector.log(message);
         },
-        shell: true,
+        // On Windows in order to run .cmd files, shell: true is required.
+        // https://github.com/nodejs/node/issues/52554
+        shell: process.platform === 'win32',
         stdio: 'pipe',
         cwd: options.cwd,
         tempDirectories: [artifactsDir],