yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: follow-up on Electron launch (#30423)

Browse Source 
Follow-up to https://github.com/microsoft/playwright/pull/30382.
This commit is contained in:
Max Schmitt 2024-04-19 00:34:07 +02:00 committed by GitHub
parent eea1f9984f
commit a1b3332e54
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/playwright-core/src/server/electron/electron.ts
View File

@ -208,7 +208,9 @@ export class Electron extends SdkObject {
progress.log(message); progress.log(message);
browserLogsCollector.log(message); browserLogsCollector.log(message);
}, },
shell: true, // On Windows in order to run .cmd files, shell: true is required.
// https://github.com/nodejs/node/issues/52554
shell: process.platform === 'win32',
stdio: 'pipe', stdio: 'pipe',
cwd: options.cwd, cwd: options.cwd,
tempDirectories: [artifactsDir], tempDirectories: [artifactsDir],