yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: fix flaky cookie roundtrip test (#19459)

Browse Source 
<img width="1676" alt="Screenshot 2022-12-14 at 2 05 29 PM"
src="https://user-images.githubusercontent.com/11915034/207726274-167d9ee7-c01b-4379-aff1-37dad979d23b.png">

Flakiness dashboard reveals on Window's variants of Chromium, the
decimal for actual vs. expected was slightly off (e.g. 1705568002.677066
vs. 1705568002.674173).

This test fix assumes it's acceptable to suppress the roundtrip floating
point difference (which appears to be constrained to Windows).

Signed-off-by: Ross Wollman <rwoll@users.noreply.github.com>
This commit is contained in:
Ross Wollman 2022-12-14 18:24:54 -05:00 committed by GitHub
parent cb4f26b41c
commit a1bb1dd94f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tests/library/browsercontext-add-cookies.spec.ts
View File

@ -15,6 +15,7 @@
* limitations under the License.
*/
import type { Cookie } from '@playwright/test';
import { contextTest as it, playwrightTest, expect } from '../config/browserTest';
it('should work @smoke', async ({ context, page, server }) => {
@ -77,7 +78,9 @@ it('should roundtrip cookie', async ({ context, page, server }) => {
await context.clearCookies();
expect(await context.cookies()).toEqual([]);
await context.addCookies(cookies);
expect(await context.cookies()).toEqual(cookies);
// Slightly different rounding on chromium win.
const normalizedExpires = (cookies: Cookie[]) => cookies.map(c => ({ ...c, expires: Math.floor(c.expires) }));
expect(normalizedExpires(await context.cookies())).toEqual(normalizedExpires(cookies));
});
it('should send cookie header', async ({ server, context }) => {