yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(debug): don't apply infinite timeouts when using debugger (#11785)

Browse Source
This commit is contained in:
Pavel Feldman 2022-02-01 11:51:37 -08:00 committed by GitHub
parent b6b60decdf
commit a3bc911a3d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/playwright-test/src/cli.ts
View File

@ -185,11 +185,10 @@ function forceRegExp(pattern: string): RegExp {
} }
function overridesFromOptions(options: { [key: string]: any }): Config { function overridesFromOptions(options: { [key: string]: any }): Config {
const isDebuggerAttached = !!require('inspector').url();
const shardPair = options.shard ? options.shard.split('/').map((t: string) => parseInt(t, 10)) : undefined; const shardPair = options.shard ? options.shard.split('/').map((t: string) => parseInt(t, 10)) : undefined;
return { return {
forbidOnly: options.forbidOnly ? true : undefined, forbidOnly: options.forbidOnly ? true : undefined,
globalTimeout: isDebuggerAttached ? 0 : (options.globalTimeout ? parseInt(options.globalTimeout, 10) : undefined), globalTimeout: options.globalTimeout ? parseInt(options.globalTimeout, 10) : undefined,
grep: options.grep ? forceRegExp(options.grep) : undefined, grep: options.grep ? forceRegExp(options.grep) : undefined,
grepInvert: options.grepInvert ? forceRegExp(options.grepInvert) : undefined, grepInvert: options.grepInvert ? forceRegExp(options.grepInvert) : undefined,
maxFailures: options.x ? 1 : (options.maxFailures ? parseInt(options.maxFailures, 10) : undefined), maxFailures: options.x ? 1 : (options.maxFailures ? parseInt(options.maxFailures, 10) : undefined),
@ -199,7 +198,7 @@ function overridesFromOptions(options: { [key: string]: any }): Config {
retries: options.retries ? parseInt(options.retries, 10) : undefined, retries: options.retries ? parseInt(options.retries, 10) : undefined,
reporter: (options.reporter && options.reporter.length) ? options.reporter.split(',').map((r: string) => [resolveReporter(r)]) : undefined, reporter: (options.reporter && options.reporter.length) ? options.reporter.split(',').map((r: string) => [resolveReporter(r)]) : undefined,
shard: shardPair ? { current: shardPair[0], total: shardPair[1] } : undefined, shard: shardPair ? { current: shardPair[0], total: shardPair[1] } : undefined,
timeout: isDebuggerAttached ? 0 : (options.timeout ? parseInt(options.timeout, 10) : undefined), timeout: options.timeout ? parseInt(options.timeout, 10) : undefined,
updateSnapshots: options.updateSnapshots ? 'all' as const : undefined, updateSnapshots: options.updateSnapshots ? 'all' as const : undefined,
workers: options.workers ? parseInt(options.workers, 10) : undefined, workers: options.workers ? parseInt(options.workers, 10) : undefined,
}; };