yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: mark screencast tests as flaky until ffmpeg migation (#3968)

Browse Source
This commit is contained in:
Pavel Feldman 2020-09-24 10:45:20 -07:00 committed by GitHub
parent 49779d5657
commit a42cd4b9aa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/fixtures.spec.ts
View File

@ -47,6 +47,7 @@ defineTestFixture('stallingConnectedRemoteServer', async ({browserType, stalling
it('should close the browser when the node process closes', test => { it('should close the browser when the node process closes', test => {
test.slow(); test.slow();
test.flaky('Flakes at least on WebKit Linux');
}, async ({connectedRemoteServer, isWindows}) => { }, async ({connectedRemoteServer, isWindows}) => {
if (isWindows) if (isWindows)
execSync(`taskkill /pid ${connectedRemoteServer.child().pid} /T /F`); execSync(`taskkill /pid ${connectedRemoteServer.child().pid} /T /F`);

10
test/screencast.spec.ts
View File

@ -196,6 +196,7 @@ class VideoPlayer {
describe('screencast', suite => { describe('screencast', suite => {
suite.slow(); suite.slow();
suite.flaky('We should migrate these to ffmpeg');
}, () => { }, () => {
it('should require artifactsPath', async ({browserType, defaultBrowserOptions}) => { it('should require artifactsPath', async ({browserType, defaultBrowserOptions}) => {
const browser = await browserType.launch({ const browser = await browserType.launch({
@ -232,9 +233,7 @@ describe('screencast', suite => {
expectAll(pixels, almostRed); expectAll(pixels, almostRed);
}); });
it('should capture navigation', test => { it('should capture navigation', async ({browser, server, videoPlayer, relativeArtifactsPath, videoDir}) => {
test.flaky();
}, async ({browser, server, videoPlayer, relativeArtifactsPath, videoDir}) => {
const context = await browser.newContext({ const context = await browser.newContext({
relativeArtifactsPath, relativeArtifactsPath,
recordVideos: true, recordVideos: true,
@ -268,6 +267,7 @@ describe('screencast', suite => {
it('should capture css transformation', (test, parameters) => { it('should capture css transformation', (test, parameters) => {
test.fail(options.WEBKIT(parameters) && options.WIN(parameters), 'Does not work on WebKit Windows'); test.fail(options.WEBKIT(parameters) && options.WIN(parameters), 'Does not work on WebKit Windows');
test.fixme(!options.HEADLESS, 'Fails on headful');
}, async ({browser, server, videoPlayer, relativeArtifactsPath, videoDir}) => { }, async ({browser, server, videoPlayer, relativeArtifactsPath, videoDir}) => {
const size = {width: 320, height: 240}; const size = {width: 320, height: 240};
// Set viewport equal to screencast frame size to avoid scaling. // Set viewport equal to screencast frame size to avoid scaling.
@ -315,7 +315,9 @@ describe('screencast', suite => {
expect(videoFiles.length).toBe(2); expect(videoFiles.length).toBe(2);
}); });
it('should scale frames down to the requested size ', async ({browser, videoPlayer, relativeArtifactsPath, videoDir, server}) => { it('should scale frames down to the requested size ', test => {
test.fixme(!options.HEADLESS, 'Fails on headful');
}, async ({browser, videoPlayer, relativeArtifactsPath, videoDir, server}) => {
const context = await browser.newContext({ const context = await browser.newContext({
relativeArtifactsPath, relativeArtifactsPath,
recordVideos: true, recordVideos: true,