From a56f97fcefb814b3082cf1aa710953588f49b551 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Fri, 21 Apr 2023 04:35:01 +0000 Subject: [PATCH] Revert "fix(inspector): fix leaking event listeners (#22535)" (#22545) This reverts commit 58b3c31f3e57ad2429e61798238063679e7f668d. Reason for revert: UI rendering hits an infinite tight loop. Reproduces locally with `npm run ctest pause.spec:357` (test hangs) Also observed on dashboard: image https://github.com/microsoft/playwright/issues/22348 --- packages/web/src/components/codeMirrorWrapper.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web/src/components/codeMirrorWrapper.tsx b/packages/web/src/components/codeMirrorWrapper.tsx index 1010210478..5ff1ab69f3 100644 --- a/packages/web/src/components/codeMirrorWrapper.tsx +++ b/packages/web/src/components/codeMirrorWrapper.tsx @@ -107,7 +107,7 @@ export const CodeMirrorWrapper: React.FC = ({ React.useEffect(() => { if (!codemirror) return; - codemirror.off('change', (codemirror as any)[listenerSymbol]); + codemirror.off('change', (codemirror as any).listenerSymbol); (codemirror as any)[listenerSymbol] = undefined; if (onChange) { (codemirror as any)[listenerSymbol] = () => onChange(codemirror.getValue());