From a70f4e64106992879c3564ad4b352a643b98103b Mon Sep 17 00:00:00 2001 From: William Bergeron-Drouin Date: Wed, 12 Jan 2022 14:04:18 -0500 Subject: [PATCH] fix(android): use isRegExp for a more robust check in different execution contexts (#11359) --- packages/playwright-core/src/client/android.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/playwright-core/src/client/android.ts b/packages/playwright-core/src/client/android.ts index 8dae7ccb82..4928cf5bfe 100644 --- a/packages/playwright-core/src/client/android.ts +++ b/packages/playwright-core/src/client/android.ts @@ -15,7 +15,7 @@ */ import fs from 'fs'; -import { isString } from '../utils/utils'; +import { isString, isRegExp } from '../utils/utils'; import * as channels from '../protocol/channels'; import { Events } from './events'; import { BrowserContext, prepareBrowserContextParams } from './browserContext'; @@ -289,7 +289,7 @@ function toSelectorChannel(selector: api.AndroidSelector): channels.AndroidSelec const toRegex = (value: RegExp | string | undefined): string | undefined => { if (value === undefined) return undefined; - if (value instanceof RegExp) + if (isRegExp(value)) return value.source; return '^' + value.replace(/[|\\{}()[\]^$+*?.]/g, '\\$&').replace(/-/g, '\\x2d') + '$'; };