yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: remove special handling for getSelection() with Firefox from tests (#35271)

Browse Source
This commit is contained in:
Henrik Skupin 2025-06-07 12:03:13 +02:00 committed by GitHub
parent 0ace76a4b1
commit a7df837809
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/page/elementhandle-select-text.spec.ts
View File

@ -22,12 +22,7 @@ it('should select textarea', async ({ page, server, browserName }) => {
const textarea = await page.$('textarea'); const textarea = await page.$('textarea');
await textarea.evaluate(textarea => textarea.value = 'some value'); await textarea.evaluate(textarea => textarea.value = 'some value');
await textarea.selectText(); await textarea.selectText();
if (browserName === 'firefox') {
expect(await textarea.evaluate(el => el.selectionStart)).toBe(0);
expect(await textarea.evaluate(el => el.selectionEnd)).toBe(10);
} else {
expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value'); expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
}
}); });
it('should select input', async ({ page, server, browserName }) => { it('should select input', async ({ page, server, browserName }) => {
@ -35,12 +30,7 @@ it('should select input', async ({ page, server, browserName }) => {
const input = await page.$('input'); const input = await page.$('input');
await input.evaluate(input => input.value = 'some value'); await input.evaluate(input => input.value = 'some value');
await input.selectText(); await input.selectText();
if (browserName === 'firefox') {
expect(await input.evaluate(el => el.selectionStart)).toBe(0);
expect(await input.evaluate(el => el.selectionEnd)).toBe(10);
} else {
expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value'); expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
}
}); });
it('should select plain div', async ({ page, server }) => { it('should select plain div', async ({ page, server }) => {

5
tests/page/locator-misc-2.spec.ts
View File

@ -78,12 +78,7 @@ it('should select textarea', async ({ page, server, browserName }) => {
const textarea = page.locator('textarea'); const textarea = page.locator('textarea');
await textarea.evaluate(textarea => (textarea as HTMLTextAreaElement).value = 'some value'); await textarea.evaluate(textarea => (textarea as HTMLTextAreaElement).value = 'some value');
await textarea.selectText(); await textarea.selectText();
if (browserName === 'firefox') {
expect(await textarea.evaluate(el => (el as HTMLTextAreaElement).selectionStart)).toBe(0);
expect(await textarea.evaluate(el => (el as HTMLTextAreaElement).selectionEnd)).toBe(10);
} else {
expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value'); expect(await page.evaluate(() => window.getSelection().toString())).toBe('some value');
}
}); });
it('should type', async ({ page }) => { it('should type', async ({ page }) => {

12
tests/page/retarget.spec.ts
View File

@ -239,12 +239,7 @@ it('input value retargeting', async ({ page, browserName }) => {
await expect(target).toHaveValue('bar'); await expect(target).toHaveValue('bar');
await target.selectText(); await target.selectText();
if (browserName === 'firefox') {
expect(await page.locator('#target').evaluate((el: HTMLInputElement) => el.selectionStart)).toBe(0);
expect(await page.locator('#target').evaluate((el: HTMLInputElement) => el.selectionEnd)).toBe(3);
} else {
expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('bar'); expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('bar');
}
}); });
} }
}); });
@ -270,14 +265,7 @@ it('selection retargeting', async ({ page, browserName }) => {
await expect(page.locator('#target')).toHaveText('foo'); await expect(page.locator('#target')).toHaveText('foo');
await target.selectText(); await target.selectText();
if (browserName === 'firefox') {
expect(await page.$eval('#target', target => {
const selection = window.getSelection()!;
return selection.anchorNode === target && selection.focusNode === target;
})).toBe(true);
} else {
expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('foo'); expect(await page.evaluate(() => window.getSelection()!.toString())).toBe('foo');
}
}); });
} }
}); });