yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(webkit): emit close on pages before clearing them (#1386)

Browse Source
This commit is contained in:
Dmitry Gozman 2020-03-13 14:43:49 -07:00 committed by GitHub
parent 69be12ae12
commit a96dec58c8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/webkit/wkBrowser.ts
View File

@ -68,9 +68,10 @@ export class WKBrowser extends platform.EventEmitter implements Browser {
_onDisconnect() {
for (const wkPage of this._wkPages.values())
wkPage.dispose();
this._wkPages.clear();
for (const context of this._contexts.values())
context._browserClosed();
// Note: previous method uses pages to issue 'close' event on them, so we clear them after.
this._wkPages.clear();
this.emit(Events.Browser.Disconnected);
}