yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(webkit): roll to r1848 (#23032)

Browse Source 
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Max Schmitt <max@schmitt.mx>
This commit is contained in:
Playwright Service 2023-05-16 03:13:58 -07:00 committed by GitHub
parent 73f9f81db4
commit aa6eb41466
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/playwright-core/browsers.json
View File

@ -33,7 +33,7 @@
},
{
"name": "webkit",
"revision": "1847",
"revision": "1848",
"installByDefault": true,
"revisionOverrides": {
"mac10.14": "1446",

2
tests/library/capabilities.spec.ts
View File

@ -236,7 +236,7 @@ it('make sure that XMLHttpRequest upload events are emitted correctly', async ({
it('loading in HTMLImageElement.prototype', async ({ page, server, browserName, isMac }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/22738' });
it.skip(browserName === 'webkit' && isMac && parseInt(os.release(), 10) < 21, 'Does not work on macOS 11');
it.skip(browserName === 'webkit' && isMac && parseInt(os.release(), 10) < 21, 'macOS 11 is frozen');
await page.goto(server.EMPTY_PAGE);
const defined = await page.evaluate(() => 'loading' in HTMLImageElement.prototype);
expect(defined).toBeTruthy();

4
tests/page/page-accessibility.spec.ts
View File

@ -15,6 +15,7 @@
* limitations under the License.
*/
import os from 'os';
import { test as it, expect } from './pageTest';
import { chromiumVersionLessThan } from '../config/utils';
@ -74,7 +75,8 @@ it('should work @smoke', async ({ page, browserName }) => {
{ role: 'textbox', name: 'Input with whitespace', value: ' ' },
{ role: 'textbox', name: '', value: 'value only' },
{ role: 'textbox', name: 'placeholder', value: 'and a value' },
{ role: 'textbox', name: 'This is a description!', value: 'and a value' }, // webkit uses the description over placeholder for the name
// due to frozen WebKit on macOS 11 we have the if/else here
{ role: 'textbox', name: parseInt(os.release(), 10) >= 21 ? 'placeholder' : 'This is a description!', value: 'and a value' }, // webkit uses the description over placeholder for the name
]
};
expect(await page.accessibility.snapshot()).toEqual(golden);