yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tracing): fix tests via tracking context close state (#8906)

Browse Source
This commit is contained in:
Pavel Feldman 2021-09-13 21:12:36 -07:00 committed by GitHub
parent 9814dfb6c1
commit aa76cb5610
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/config/browserTest.ts
View File

@ -133,9 +133,11 @@ export const playwrightFixtures: Fixtures<PlaywrightTestOptions & PlaywrightTest
}, },
contextFactory: async ({ browser, contextOptions, trace }, run, testInfo) => { contextFactory: async ({ browser, contextOptions, trace }, run, testInfo) => {
const contexts: BrowserContext[] = []; const contexts = new Map<BrowserContext, { closed: boolean }>();
await run(async options => { await run(async options => {
const context = await browser.newContext({ ...contextOptions, ...options }); const context = await browser.newContext({ ...contextOptions, ...options });
contexts.set(context, { closed: false });
context.on('close', () => contexts.get(context).closed = true);
if (trace) if (trace)
await context.tracing.start({ screenshots: true, snapshots: true }); await context.tracing.start({ screenshots: true, snapshots: true });
(context as any)._csi = { (context as any)._csi = {
@ -146,12 +148,11 @@ export const playwrightFixtures: Fixtures<PlaywrightTestOptions & PlaywrightTest
return (error?: Error) => newStep?.complete(error); return (error?: Error) => newStep?.complete(error);
}, },
}; };
contexts.push(context);
return context; return context;
}); });
await Promise.all(contexts.map(async context => { await Promise.all([...contexts.keys()].map(async context => {
const videos = context.pages().map(p => p.video()).filter(Boolean); const videos = context.pages().map(p => p.video()).filter(Boolean);
if (!(context as any)._closed && trace) { if (trace && !contexts.get(context)!.closed) {
const tracePath = testInfo.outputPath('trace.zip'); const tracePath = testInfo.outputPath('trace.zip');
await context.tracing.stop({ path: tracePath }); await context.tracing.stop({ path: tracePath });
testInfo.attachments.push({ name: 'trace', path: tracePath, contentType: 'application/zip' }); testInfo.attachments.push({ name: 'trace', path: tracePath, contentType: 'application/zip' });