From ac90a47b73cc42909c93009d4fcaf10b7b14e05f Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Tue, 18 Jun 2024 12:12:19 -0700
Subject: [PATCH] fix(click): do not retarget <a> to the parent <label>
 (#31368)

Fixes #31359.
---
 .../src/server/injected/injectedScript.ts         |  2 +-
 tests/page/retarget.spec.ts                       | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/packages/playwright-core/src/server/injected/injectedScript.ts b/packages/playwright-core/src/server/injected/injectedScript.ts
index 8aedc6f0b1..2323648bae 100644
--- a/packages/playwright-core/src/server/injected/injectedScript.ts
+++ b/packages/playwright-core/src/server/injected/injectedScript.ts
@@ -478,7 +478,7 @@ export class InjectedScript {
         element = element.closest('button, [role=button], [role=checkbox], [role=radio]') || element;
     }
     if (behavior === 'follow-label') {
-      if (!element.matches('input, textarea, button, select, [role=button], [role=checkbox], [role=radio]') &&
+      if (!element.matches('a, input, textarea, button, select, [role=link], [role=button], [role=checkbox], [role=radio]') &&
         !(element as any).isContentEditable) {
         // Go up to the label that might be connected to the input/textarea.
         element = element.closest('label') || element;
diff --git a/tests/page/retarget.spec.ts b/tests/page/retarget.spec.ts
index 65daf1e205..94e0f440e7 100644
--- a/tests/page/retarget.spec.ts
+++ b/tests/page/retarget.spec.ts
@@ -377,3 +377,18 @@ it('check retargeting', async ({ page, asset }) => {
     });
   }
 });
+
+it('should not retarget anchor into parent label', async ({ page }) => {
+  await page.setContent(`
+    <label disabled>Text<a href='#' onclick='window.__clicked=1'>Target</a></label>
+  `);
+  await page.locator('a').click();
+  expect(await page.evaluate('window.__clicked')).toBe(1);
+
+  await page.setContent(`
+    <input type="radio" id="input-id" checked disabled />
+    <label for="input-id">Text<a href='#' onclick='window.__clicked=2'>Target</a></label>
+  `);
+  await page.locator('a').click();
+  expect(await page.evaluate('window.__clicked')).toBe(2);
+});