yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(runner): do not restart worker after skipping tests (#7511)

Browse Source
This commit is contained in:
Yury Semikhatsky 2021-07-08 09:36:28 -07:00 committed by GitHub
parent e4698b5f6a
commit b2742976a8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 47 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/workerRunner.ts
View File

@ -338,7 +338,7 @@ export class WorkerRunner extends EventEmitter {
if (!preserveOutput)
await removeFolderAsync(testInfo.outputDir).catch(e => {});
if (testInfo.status !== 'passed') {
if (testInfo.status !== 'passed' && testInfo.status !== 'skipped') {
this._failedTestId = testId;
this._reportDoneAndStop();
}

46
tests/playwright-test/worker-index.spec.ts
View File

@ -69,6 +69,52 @@ test('should reuse worker for multiple tests', async ({ runInlineTest }) => {
expect(result.exitCode).toBe(0);
});
test('should reuse worker after test.fixme()', async ({ runInlineTest }) => {
const result = await runInlineTest({
'a.test.js': `
const { test } = pwt;
test('succeeds 1', async ({}, testInfo) => {
expect(testInfo.workerIndex).toBe(0);
});
test('fixme 1', async ({}, testInfo) => {
test.fixme();
expect(testInfo.workerIndex).toBe(0);
});
test('succeeds 2', async ({}, testInfo) => {
expect(testInfo.workerIndex).toBe(0);
});
`,
});
expect(result.passed).toBe(2);
expect(result.skipped).toBe(1);
expect(result.exitCode).toBe(0);
});
test('should reuse worker after test.skip()', async ({ runInlineTest }) => {
const result = await runInlineTest({
'a.test.js': `
const { test } = pwt;
test('succeeds 1', async ({}, testInfo) => {
expect(testInfo.workerIndex).toBe(0);
});
test('skip 1', async ({}, testInfo) => {
test.skip();
expect(testInfo.workerIndex).toBe(0);
});
test('succeeds 2', async ({}, testInfo) => {
expect(testInfo.workerIndex).toBe(0);
});
`,
});
expect(result.passed).toBe(2);
expect(result.skipped).toBe(1);
expect(result.exitCode).toBe(0);
});
test('should not reuse worker for different suites', async ({ runInlineTest }) => {
const result = await runInlineTest({
'playwright.config.ts': `