From b4b7c5eeefa65aff1bbe1ccf8e23635b55dddec4 Mon Sep 17 00:00:00 2001
From: Pavel Feldman <pavel.feldman@gmail.com>
Date: Fri, 24 Jan 2020 17:42:24 -0800
Subject: [PATCH] feat(webkit): enable user-data-dir tests for all platforms
 (#646)

Fixes #560
---
 package.json          | 2 +-
 src/server/webkit.ts  | 4 ++--
 test/launcher.spec.js | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/package.json b/package.json
index e0de58ecac..64a05513a9 100644
--- a/package.json
+++ b/package.json
@@ -10,7 +10,7 @@
   "playwright": {
     "chromium_revision": "733125",
     "firefox_revision": "1018",
-    "webkit_revision": "1111"
+    "webkit_revision": "1112"
   },
   "scripts": {
     "unit": "node test/test.js",
diff --git a/src/server/webkit.ts b/src/server/webkit.ts
index 82795766fa..126f610143 100644
--- a/src/server/webkit.ts
+++ b/src/server/webkit.ts
@@ -79,9 +79,9 @@ export class WebKit implements BrowserType {
 
     let userDataDir: string;
     let temporaryUserDataDir: string | null = null;
-    const userDataDirArg = webkitArguments.find(arg => arg.startsWith('--user-data-dir'));
+    const userDataDirArg = webkitArguments.find(arg => arg.startsWith('--user-data-dir='));
     if (userDataDirArg) {
-      userDataDir = userDataDirArg.substr('--user-data-dir'.length).trim();
+      userDataDir = userDataDirArg.substr('--user-data-dir='.length).trim();
     } else {
       userDataDir = await mkdtempAsync(WEBKIT_PROFILE_PATH);
       temporaryUserDataDir = userDataDir;
diff --git a/test/launcher.spec.js b/test/launcher.spec.js
index fc6be464f8..f0fe24fa46 100644
--- a/test/launcher.spec.js
+++ b/test/launcher.spec.js
@@ -288,7 +288,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p
     });
   });
 
-  describe.skip(WEBKIT)('Playwright.launch({userDataDir})', function() {
+  describe('Playwright.launch({userDataDir})', function() {
     it('userDataDir option', async({server}) => {
       const userDataDir = await mkdtempAsync(TMP_FOLDER);
       const options = Object.assign({userDataDir}, defaultBrowserOptions);