yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(webkit): enable user-data-dir tests for all platforms (#646)

Browse Source 
Fixes #560
This commit is contained in:
Pavel Feldman 2020-01-24 17:42:24 -08:00 committed by GitHub
parent 63d5a7347d
commit b4b7c5eeef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -10,7 +10,7 @@
"playwright": { "playwright": {
"chromium_revision": "733125", "chromium_revision": "733125",
"firefox_revision": "1018", "firefox_revision": "1018",
"webkit_revision": "1111" "webkit_revision": "1112"
}, },
"scripts": { "scripts": {
"unit": "node test/test.js", "unit": "node test/test.js",

4
src/server/webkit.ts
View File

@ -79,9 +79,9 @@ export class WebKit implements BrowserType {
let userDataDir: string; let userDataDir: string;
let temporaryUserDataDir: string | null = null; let temporaryUserDataDir: string | null = null;
const userDataDirArg = webkitArguments.find(arg => arg.startsWith('--user-data-dir')); const userDataDirArg = webkitArguments.find(arg => arg.startsWith('--user-data-dir='));
if (userDataDirArg) { if (userDataDirArg) {
userDataDir = userDataDirArg.substr('--user-data-dir'.length).trim(); userDataDir = userDataDirArg.substr('--user-data-dir='.length).trim();
} else { } else {
userDataDir = await mkdtempAsync(WEBKIT_PROFILE_PATH); userDataDir = await mkdtempAsync(WEBKIT_PROFILE_PATH);
temporaryUserDataDir = userDataDir; temporaryUserDataDir = userDataDir;

2
test/launcher.spec.js
View File

@ -288,7 +288,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p
}); });
}); });
describe.skip(WEBKIT)('Playwright.launch({userDataDir})', function() { describe('Playwright.launch({userDataDir})', function() {
it('userDataDir option', async({server}) => { it('userDataDir option', async({server}) => {
const userDataDir = await mkdtempAsync(TMP_FOLDER); const userDataDir = await mkdtempAsync(TMP_FOLDER);
const options = Object.assign({userDataDir}, defaultBrowserOptions); const options = Object.assign({userDataDir}, defaultBrowserOptions);