diff --git a/docs/src/api/class-frame.md b/docs/src/api/class-frame.md index 7244592f6c..7120e44887 100644 --- a/docs/src/api/class-frame.md +++ b/docs/src/api/class-frame.md @@ -887,18 +887,6 @@ await locator.ClickAsync(); * since: v1.17 -## method: Frame.get -* since: v1.27 -- returns: <[Locator]> - -%%-template-locator-root-locator-%% - -### param: Frame.get.selector = %%-find-selector-%% -* since: v1.27 -### option: Frame.get.-inline- = %%-locator-options-list-v1.14-%% -* since: v1.27 - - ## async method: Frame.getAttribute * since: v1.8 - returns: <[null]|[string]> diff --git a/docs/src/api/class-framelocator.md b/docs/src/api/class-framelocator.md index 0cc0de2a0e..920c0c8411 100644 --- a/docs/src/api/class-framelocator.md +++ b/docs/src/api/class-framelocator.md @@ -114,18 +114,6 @@ in that iframe. * since: v1.17 -## method: FrameLocator.get -* since: v1.27 -- returns: <[Locator]> - -%%-template-locator-locator-%% - -### param: FrameLocator.get.selector = %%-find-selector-%% -* since: v1.27 -### option: FrameLocator.get.-inline- = %%-locator-options-list-v1.14-%% -* since: v1.27 - - ## method: FrameLocator.getByLabelText * since: v1.27 - returns: <[Locator]> diff --git a/docs/src/api/class-locator.md b/docs/src/api/class-locator.md index 0f15c9fbc9..233772b357 100644 --- a/docs/src/api/class-locator.md +++ b/docs/src/api/class-locator.md @@ -618,18 +618,6 @@ await locator.ClickAsync(); * since: v1.17 -## method: Locator.get -* since: v1.27 -- returns: <[Locator]> - -%%-template-locator-locator-%% - -### param: Locator.get.selector = %%-find-selector-%% -* since: v1.27 -### option: Locator.get.-inline- = %%-locator-options-list-v1.14-%% -* since: v1.27 - - ## async method: Locator.getAttribute * since: v1.14 - returns: <[null]|[string]> diff --git a/docs/src/api/class-page.md b/docs/src/api/class-page.md index fa08796f06..cee5229031 100644 --- a/docs/src/api/class-page.md +++ b/docs/src/api/class-page.md @@ -2162,18 +2162,6 @@ await locator.ClickAsync(); An array of all frames attached to the page. -## method: Page.get -* since: v1.27 -- returns: <[Locator]> - -%%-template-locator-root-locator-%% - -### param: Page.get.selector = %%-find-selector-%% -* since: v1.27 -### option: Page.get.-inline- = %%-locator-options-list-v1.14-%% -* since: v1.27 - - ## async method: Page.getAttribute * since: v1.8 - returns: <[null]|[string]> diff --git a/packages/playwright-core/src/client/frame.ts b/packages/playwright-core/src/client/frame.ts index b06910f478..20ab160358 100644 --- a/packages/playwright-core/src/client/frame.ts +++ b/packages/playwright-core/src/client/frame.ts @@ -299,10 +299,6 @@ export class Frame extends ChannelOwner implements api.Fr return new Locator(this, selector, options); } - get(selector: string, options?: LocatorOptions): Locator { - return this.locator(selector, options); - } - getByTestId(testId: string): Locator { return this.locator(Locator.getByTestIdSelector(testId)); } diff --git a/packages/playwright-core/src/client/locator.ts b/packages/playwright-core/src/client/locator.ts index e50f0af6e4..c169934012 100644 --- a/packages/playwright-core/src/client/locator.ts +++ b/packages/playwright-core/src/client/locator.ts @@ -189,10 +189,6 @@ export class Locator implements api.Locator { return new Locator(this._frame, this._selector + ' >> ' + selector, options); } - get(selector: string, options?: LocatorOptions): Locator { - return this.locator(selector, options); - } - getByTestId(testId: string): Locator { return this.locator(Locator.getByTestIdSelector(testId)); } @@ -383,10 +379,6 @@ export class FrameLocator implements api.FrameLocator { return new Locator(this._frame, this._frameSelector + ' >> control=enter-frame >> ' + selector, options); } - get(selector: string, options?: LocatorOptions): Locator { - return this.locator(selector, options); - } - getByTestId(testId: string): Locator { return this.locator(Locator.getByTestIdSelector(testId)); } diff --git a/packages/playwright-core/src/client/page.ts b/packages/playwright-core/src/client/page.ts index ac27a28a50..65ed01b573 100644 --- a/packages/playwright-core/src/client/page.ts +++ b/packages/playwright-core/src/client/page.ts @@ -564,10 +564,6 @@ export class Page extends ChannelOwner implements api.Page return this.mainFrame().locator(selector, options); } - get(selector: string, options?: LocatorOptions): Locator { - return this.mainFrame().locator(selector, options); - } - getByTestId(testId: string): Locator { return this.mainFrame().getByTestId(testId); } diff --git a/packages/playwright-core/types/types.d.ts b/packages/playwright-core/types/types.d.ts index b8b6892791..33bc0c443f 100644 --- a/packages/playwright-core/types/types.d.ts +++ b/packages/playwright-core/types/types.d.ts @@ -2434,32 +2434,6 @@ export interface Page { */ frames(): Array; - /** - * The method returns an element locator that can be used to perform actions on this page / frame. Locator is resolved to - * the element immediately before performing an action, so a series of actions on the same locator can in fact be performed - * on different DOM elements. That would happen if the DOM structure between those actions has changed. - * - * [Learn more about locators](https://playwright.dev/docs/locators). - * @param selector A selector to use when resolving DOM element. See [working with selectors](https://playwright.dev/docs/selectors) for more details. - * @param options - */ - get(selector: string, options?: { - /** - * Matches elements containing an element that matches an inner locator. Inner locator is queried against the outer one. - * For example, `article` that has `text=Playwright` matches `
Playwright
`. - * - * Note that outer and inner locators must belong to the same frame. Inner locator must not contain [FrameLocator]s. - */ - has?: Locator; - - /** - * Matches elements containing specified text somewhere inside, possibly in a child or a descendant element. When passed a - * [string], matching is case-insensitive and searches for a substring. For example, `"Playwright"` matches - * `
Playwright
`. - */ - hasText?: string|RegExp; - }): Locator; - /** * Returns element attribute value. * @param selector A selector to search for an element. If there are multiple elements satisfying the selector, the first will be used. See [working with selectors](https://playwright.dev/docs/selectors) for more details. @@ -5494,32 +5468,6 @@ export interface Frame { */ frameLocator(selector: string): FrameLocator; - /** - * The method returns an element locator that can be used to perform actions on this page / frame. Locator is resolved to - * the element immediately before performing an action, so a series of actions on the same locator can in fact be performed - * on different DOM elements. That would happen if the DOM structure between those actions has changed. - * - * [Learn more about locators](https://playwright.dev/docs/locators). - * @param selector A selector to use when resolving DOM element. See [working with selectors](https://playwright.dev/docs/selectors) for more details. - * @param options - */ - get(selector: string, options?: { - /** - * Matches elements containing an element that matches an inner locator. Inner locator is queried against the outer one. - * For example, `article` that has `text=Playwright` matches `
Playwright
`. - * - * Note that outer and inner locators must belong to the same frame. Inner locator must not contain [FrameLocator]s. - */ - has?: Locator; - - /** - * Matches elements containing specified text somewhere inside, possibly in a child or a descendant element. When passed a - * [string], matching is case-insensitive and searches for a substring. For example, `"Playwright"` matches - * `
Playwright
`. - */ - hasText?: string|RegExp; - }): Locator; - /** * Returns element attribute value. * @param selector A selector to search for an element. If there are multiple elements satisfying the selector, the first will be used. See [working with selectors](https://playwright.dev/docs/selectors) for more details. @@ -9909,31 +9857,6 @@ export interface Locator { */ frameLocator(selector: string): FrameLocator; - /** - * The method finds an element matching the specified selector in the locator's subtree. It also accepts filter options, - * similar to [locator.filter([options])](https://playwright.dev/docs/api/class-locator#locator-filter) method. - * - * [Learn more about locators](https://playwright.dev/docs/locators). - * @param selector A selector to use when resolving DOM element. See [working with selectors](https://playwright.dev/docs/selectors) for more details. - * @param options - */ - get(selector: string, options?: { - /** - * Matches elements containing an element that matches an inner locator. Inner locator is queried against the outer one. - * For example, `article` that has `text=Playwright` matches `
Playwright
`. - * - * Note that outer and inner locators must belong to the same frame. Inner locator must not contain [FrameLocator]s. - */ - has?: Locator; - - /** - * Matches elements containing specified text somewhere inside, possibly in a child or a descendant element. When passed a - * [string], matching is case-insensitive and searches for a substring. For example, `"Playwright"` matches - * `
Playwright
`. - */ - hasText?: string|RegExp; - }): Locator; - /** * Returns element attribute value. * @param name Attribute name to get the value for. @@ -15152,31 +15075,6 @@ export interface FrameLocator { */ frameLocator(selector: string): FrameLocator; - /** - * The method finds an element matching the specified selector in the locator's subtree. It also accepts filter options, - * similar to [locator.filter([options])](https://playwright.dev/docs/api/class-locator#locator-filter) method. - * - * [Learn more about locators](https://playwright.dev/docs/locators). - * @param selector A selector to use when resolving DOM element. See [working with selectors](https://playwright.dev/docs/selectors) for more details. - * @param options - */ - get(selector: string, options?: { - /** - * Matches elements containing an element that matches an inner locator. Inner locator is queried against the outer one. - * For example, `article` that has `text=Playwright` matches `
Playwright
`. - * - * Note that outer and inner locators must belong to the same frame. Inner locator must not contain [FrameLocator]s. - */ - has?: Locator; - - /** - * Matches elements containing specified text somewhere inside, possibly in a child or a descendant element. When passed a - * [string], matching is case-insensitive and searches for a substring. For example, `"Playwright"` matches - * `
Playwright
`. - */ - hasText?: string|RegExp; - }): Locator; - /** * Allows locating input elements by the text of the associated label. For example, this method will find the input by * label text Password in the following DOM: diff --git a/tests/page/locator-frame.spec.ts b/tests/page/locator-frame.spec.ts index e2cf76902b..42e5e3b582 100644 --- a/tests/page/locator-frame.spec.ts +++ b/tests/page/locator-frame.spec.ts @@ -69,7 +69,7 @@ async function routeAmbiguous(page: Page) { it('should work for iframe @smoke', async ({ page, server }) => { await routeIframe(page); await page.goto(server.EMPTY_PAGE); - const button = page.frameLocator('iframe').get('button'); + const button = page.frameLocator('iframe').locator('button'); await button.waitFor(); expect(await button.innerText()).toBe('Hello iframe'); await expect(button).toHaveText('Hello iframe'); @@ -79,7 +79,7 @@ it('should work for iframe @smoke', async ({ page, server }) => { it('should work for nested iframe', async ({ page, server }) => { await routeIframe(page); await page.goto(server.EMPTY_PAGE); - const button = page.frameLocator('iframe').frameLocator('iframe').get('button'); + const button = page.frameLocator('iframe').frameLocator('iframe').locator('button'); await button.waitFor(); expect(await button.innerText()).toBe('Hello nested iframe'); await expect(button).toHaveText('Hello nested iframe'); @@ -89,15 +89,15 @@ it('should work for nested iframe', async ({ page, server }) => { it('should work for $ and $$', async ({ page, server }) => { await routeIframe(page); await page.goto(server.EMPTY_PAGE); - const locator = page.frameLocator('iframe').get('button'); + const locator = page.frameLocator('iframe').locator('button'); await expect(locator).toHaveText('Hello iframe'); - const spans = page.frameLocator('iframe').get('span'); + const spans = page.frameLocator('iframe').locator('span'); await expect(spans).toHaveCount(2); }); it('should wait for frame', async ({ page, server }) => { await page.goto(server.EMPTY_PAGE); - const error = await page.frameLocator('iframe').get('span').click({ timeout: 1000 }).catch(e => e); + const error = await page.frameLocator('iframe').locator('span').click({ timeout: 1000 }).catch(e => e); expect(error.message).toContain('waiting for frame "iframe"'); }); diff --git a/tests/page/locator-query.spec.ts b/tests/page/locator-query.spec.ts index 6d729d4c90..80e477254d 100644 --- a/tests/page/locator-query.spec.ts +++ b/tests/page/locator-query.spec.ts @@ -175,8 +175,8 @@ it('should enforce same frame for has/leftOf/rightOf/above/below/near', async ({ it('alias methods coverage', async ({ page }) => { await page.setContent(`
`); - await expect(page.get('button')).toHaveCount(1); - await expect(page.get('div').get('button')).toHaveCount(1); - await expect(page.get('div').getByRole('button')).toHaveCount(1); - await expect(page.mainFrame().get('button')).toHaveCount(1); + await expect(page.locator('button')).toHaveCount(1); + await expect(page.locator('div').locator('button')).toHaveCount(1); + await expect(page.locator('div').getByRole('button')).toHaveCount(1); + await expect(page.mainFrame().locator('button')).toHaveCount(1); }); diff --git a/tests/page/selectors-css.spec.ts b/tests/page/selectors-css.spec.ts index f3ca8afbcc..2732307b02 100644 --- a/tests/page/selectors-css.spec.ts +++ b/tests/page/selectors-css.spec.ts @@ -418,7 +418,7 @@ it('getByTestId should work', async ({ page }) => { await page.setContent('
Hello world
'); await expect(page.getByTestId('Hello')).toHaveText('Hello world'); await expect(page.mainFrame().getByTestId('Hello')).toHaveText('Hello world'); - await expect(page.get('div').getByTestId('Hello')).toHaveText('Hello world'); + await expect(page.locator('div').getByTestId('Hello')).toHaveText('Hello world'); }); it('getByTestId should escape id', async ({ page }) => { diff --git a/tests/page/selectors-role.spec.ts b/tests/page/selectors-role.spec.ts index af9a27c26f..8df22dc7d5 100644 --- a/tests/page/selectors-role.spec.ts +++ b/tests/page/selectors-role.spec.ts @@ -25,25 +25,25 @@ test('should detect roles', async ({ page }) => {
Hello
I am a dialog
`); - expect(await page.get(`role=button`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ]); - expect(await page.get(`role=listbox`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=listbox`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ]); - expect(await page.get(`role=combobox`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=combobox`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ]); - expect(await page.get(`role=heading`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=heading`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `

Heading

`, ]); - expect(await page.get(`role=group`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=group`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `
Hello
`, ]); - expect(await page.get(`role=dialog`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=dialog`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `
I am a dialog
`, ]); - expect(await page.get(`role=menuitem`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=menuitem`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ]); expect(await page.getByRole('menuitem').evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ]); @@ -60,12 +60,12 @@ test('should support selected', async ({ page }) => {
Hello
`); - expect(await page.get(`role=option[selected]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=option[selected]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, `
Hi
`, ]); - expect(await page.get(`role=option[selected=true]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=option[selected=true]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, `
Hi
`, ]); @@ -74,7 +74,7 @@ test('should support selected', async ({ page }) => { `
Hi
`, ]); - expect(await page.get(`role=option[selected=false]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=option[selected=false]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, `
Hello
`, ]); @@ -95,11 +95,11 @@ test('should support checked', async ({ page }) => { `); await page.$eval('[indeterminate]', input => (input as HTMLInputElement).indeterminate = true); - expect(await page.get(`role=checkbox[checked]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=checkbox[checked]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, `
Hi
`, ]); - expect(await page.get(`role=checkbox[checked=true]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=checkbox[checked=true]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, `
Hi
`, ]); @@ -108,7 +108,7 @@ test('should support checked', async ({ page }) => { `
Hi
`, ]); - expect(await page.get(`role=checkbox[checked=false]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=checkbox[checked=false]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, `
Hello
`, `
Unknown
`, @@ -119,10 +119,10 @@ test('should support checked', async ({ page }) => { `
Unknown
`, ]); - expect(await page.get(`role=checkbox[checked="mixed"]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=checkbox[checked="mixed"]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ]); - expect(await page.get(`role=checkbox`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=checkbox`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ``, ``, @@ -139,16 +139,16 @@ test('should support pressed', async ({ page }) => { `); - expect(await page.get(`role=button[pressed]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[pressed]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ]); - expect(await page.get(`role=button[pressed=true]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[pressed=true]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ]); expect(await page.getByRole('button', { pressed: true }).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ]); - expect(await page.get(`role=button[pressed=false]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[pressed=false]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ``, ]); @@ -156,10 +156,10 @@ test('should support pressed', async ({ page }) => { ``, ``, ]); - expect(await page.get(`role=button[pressed="mixed"]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[pressed="mixed"]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ]); - expect(await page.get(`role=button`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ``, ``, @@ -173,16 +173,16 @@ test('should support expanded', async ({ page }) => { `); - expect(await page.get(`role=button[expanded]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[expanded]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ]); - expect(await page.get(`role=button[expanded=true]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[expanded=true]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ]); expect(await page.getByRole('button', { expanded: true }).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ]); - expect(await page.get(`role=button[expanded=false]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[expanded=false]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ``, ]); @@ -202,12 +202,12 @@ test('should support disabled', async ({ page }) => { `); - expect(await page.get(`role=button[disabled]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[disabled]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ``, ``, ]); - expect(await page.get(`role=button[disabled=true]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[disabled=true]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ``, ``, @@ -217,7 +217,7 @@ test('should support disabled', async ({ page }) => { ``, ``, ]); - expect(await page.get(`role=button[disabled=false]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[disabled=false]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ``, ]); @@ -233,19 +233,19 @@ test('should support level', async ({ page }) => {

Hi

Bye
`); - expect(await page.get(`role=heading[level=1]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=heading[level=1]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `

Hello

`, ]); expect(await page.getByRole('heading', { level: 1 }).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `

Hello

`, ]); - expect(await page.get(`role=heading[level=3]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=heading[level=3]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `

Hi

`, ]); expect(await page.getByRole('heading', { level: 3 }).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `

Hi

`, ]); - expect(await page.get(`role=heading[level=5]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=heading[level=5]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `
Bye
`, ]); }); @@ -277,13 +277,13 @@ test('should filter hidden, unless explicitly asked for', async ({ page }) => { addButton(document.getElementById('host2'), 'Shadow2'); `); - expect(await page.get(`role=button`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ``, ``, ``, ]); - expect(await page.get(`role=button[include-hidden]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[include-hidden]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ``, ``, @@ -295,7 +295,7 @@ test('should filter hidden, unless explicitly asked for', async ({ page }) => { ``, ``, ]); - expect(await page.get(`role=button[include-hidden=true]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[include-hidden=true]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ``, ``, @@ -307,7 +307,7 @@ test('should filter hidden, unless explicitly asked for', async ({ page }) => { ``, ``, ]); - expect(await page.get(`role=button[include-hidden=false]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[include-hidden=false]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ``, ``, @@ -323,18 +323,18 @@ test('should support name', async ({ page }) => { `); - expect(await page.get(`role=button[name="Hello"]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[name="Hello"]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `
`, ]); expect(await page.getByRole('button', { name: 'Hello' }).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `
`, ]); - expect(await page.get(`role=button[name*="all"]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[name*="all"]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `
`, ]); - expect(await page.get(`role=button[name=/^H[ae]llo$/]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[name=/^H[ae]llo$/]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `
`, `
`, ]); @@ -343,7 +343,7 @@ test('should support name', async ({ page }) => { `
`, ]); - expect(await page.get(`role=button[name=/h.*o/i]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[name=/h.*o/i]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `
`, `
`, ]); @@ -352,7 +352,7 @@ test('should support name', async ({ page }) => { `
`, ]); - expect(await page.get(`role=button[name="Hello"][include-hidden]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[name="Hello"][include-hidden]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `
`, ``, ]); @@ -361,10 +361,10 @@ test('should support name', async ({ page }) => { ``, ]); - expect(await page.get(`role=button[name=Hello]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[name=Hello]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ `
`, ]); - expect(await page.get(`role=button[name=123][include-hidden]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ + expect(await page.locator(`role=button[name=123][include-hidden]`).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ ``, ]); expect(await page.getByRole('button', { name: '123', includeHidden: true }).evaluateAll(els => els.map(e => e.outerHTML))).toEqual([ diff --git a/tests/page/selectors-text.spec.ts b/tests/page/selectors-text.spec.ts index d79c3b1c67..3b369a5260 100644 --- a/tests/page/selectors-text.spec.ts +++ b/tests/page/selectors-text.spec.ts @@ -460,5 +460,5 @@ it('getByLabelText should work', async ({ page, asset }) => { expect(await page.getByText('Name').evaluate(e => e.nodeName)).toBe('LABEL'); expect(await page.getByLabelText('Name').evaluate(e => e.nodeName)).toBe('INPUT'); expect(await page.mainFrame().getByLabelText('Name').evaluate(e => e.nodeName)).toBe('INPUT'); - expect(await page.get('div').getByLabelText('Name').evaluate(e => e.nodeName)).toBe('INPUT'); + expect(await page.locator('div').getByLabelText('Name').evaluate(e => e.nodeName)).toBe('INPUT'); });