From b5195122d95edb45463df54fa081505d5957eff2 Mon Sep 17 00:00:00 2001
From: Yury Semikhatsky <yurys@chromium.org>
Date: Wed, 5 Apr 2023 14:23:06 -0700
Subject: [PATCH] chore: return promise from tele receiver dispatch (#22218)

---
 .../src/isomorphic/teleReceiver.ts            | 25 +++++++++++++------
 packages/trace-viewer/src/ui/watchMode.tsx    |  2 +-
 2 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/packages/playwright-test/src/isomorphic/teleReceiver.ts b/packages/playwright-test/src/isomorphic/teleReceiver.ts
index 79a2a93f9b..df3350f408 100644
--- a/packages/playwright-test/src/isomorphic/teleReceiver.ts
+++ b/packages/playwright-test/src/isomorphic/teleReceiver.ts
@@ -107,6 +107,11 @@ export type JsonTestStepEnd = {
   error?: TestError;
 };
 
+export type JsonEvent = {
+  method: string;
+  params: any
+};
+
 export class TeleReporterReceiver {
   private _rootSuite: TeleSuite;
   private _pathSeparator: string;
@@ -120,8 +125,8 @@ export class TeleReporterReceiver {
     this._reporter = reporter;
   }
 
-  dispatch(message: any) {
-    const { method, params }: { method: string, params: any } = message;
+  dispatch(message: JsonEvent): Promise<void> | undefined {
+    const { method, params } = message;
     if (method === 'onBegin') {
       this._onBegin(params.config, params.projects);
       return;
@@ -150,10 +155,10 @@ export class TeleReporterReceiver {
       this._onStdIO(params.type, params.testId, params.resultId, params.data, params.isBase64);
       return;
     }
-    if (method === 'onEnd') {
-      this._onEnd(params.result);
-      return;
-    }
+    if (method === 'onEnd')
+      return this._onEnd(params.result);
+    if (method === 'onExit')
+      return this._onExit();
   }
 
   private _onBegin(config: JsonConfig, projects: JsonProject[]) {
@@ -258,8 +263,12 @@ export class TeleReporterReceiver {
       this._reporter.onStdErr?.(chunk, test, result);
   }
 
-  private _onEnd(result: FullResult) {
-    this._reporter.onEnd?.(result);
+  private _onEnd(result: FullResult): Promise<void> | undefined {
+    return this._reporter.onEnd?.(result) || undefined;
+  }
+
+  private _onExit(): Promise<void> | undefined {
+    return this._reporter.onExit?.();
   }
 
   private _parseConfig(config: JsonConfig): FullConfig {
diff --git a/packages/trace-viewer/src/ui/watchMode.tsx b/packages/trace-viewer/src/ui/watchMode.tsx
index 7d71d91165..6ecbb68fe9 100644
--- a/packages/trace-viewer/src/ui/watchMode.tsx
+++ b/packages/trace-viewer/src/ui/watchMode.tsx
@@ -618,7 +618,7 @@ const refreshRootSuite = (eraseResults: boolean): Promise<void> => {
     return;
   }
 
-  receiver?.dispatch(message);
+  receiver?.dispatch(message)?.catch(() => {});
 };
 
 const sendMessage = async (method: string, params: any) => {