test: skip tests that modify env in non-default mode (#15725)

This commit is contained in:
Dmitry Gozman 2022-07-15 13:06:19 -07:00 committed by GitHub
parent a56d801352
commit b637ce1250
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -639,6 +639,7 @@ test.describe('should emit page-level network events with service worker fetch h
}); });
test.describe('PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1', () => { test.describe('PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1', () => {
test.skip(({ mode }) => mode !== 'default', 'Cannot set env variables in non-default');
test.beforeAll(() => process.env.PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS = '1'); test.beforeAll(() => process.env.PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS = '1');
test.afterAll(() => delete process.env.PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS); test.afterAll(() => delete process.env.PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS);
@ -841,7 +842,7 @@ test.describe('PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1', () => {
res.write(` res.write(`
<script> <script>
window.registrationPromise = navigator.serviceWorker.register('/transparent-service-worker.js'); window.registrationPromise = navigator.serviceWorker.register('/transparent-service-worker.js');
</script> </script>
`); `);
res.end(); res.end();
}); });
@ -850,11 +851,11 @@ test.describe('PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1', () => {
res.write(` res.write(`
self.addEventListener("fetch", (event) => { self.addEventListener("fetch", (event) => {
// actually make the request // actually make the request
const responsePromise = fetch(event.request); const responsePromise = fetch(event.request);
// send it back to the page // send it back to the page
event.respondWith(responsePromise); event.respondWith(responsePromise);
}); });
self.addEventListener("activate", (event) => { self.addEventListener("activate", (event) => {
event.waitUntil(clients.claim()); event.waitUntil(clients.claim());
}); });
@ -904,7 +905,7 @@ test.describe('PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1', () => {
res.write(` res.write(`
<script> <script>
window.registrationPromise = navigator.serviceWorker.register('/complex-service-worker.js'); window.registrationPromise = navigator.serviceWorker.register('/complex-service-worker.js');
</script> </script>
`); `);
res.end(); res.end();
}); });
@ -919,7 +920,7 @@ test.describe('PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1', () => {
}) })
); );
}); });
// Opt to handle FetchEvent's from the page // Opt to handle FetchEvent's from the page
self.addEventListener("fetch", (event) => { self.addEventListener("fetch", (event) => {
event.respondWith( event.respondWith(
@ -927,23 +928,23 @@ test.describe('PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1', () => {
// 1. Try to first serve directly from caches // 1. Try to first serve directly from caches
let response = await caches.match(event.request); let response = await caches.match(event.request);
if (response) return response; if (response) return response;
// 2. Re-write request for /foo to /bar // 2. Re-write request for /foo to /bar
if (event.request.url.endsWith("foo")) return fetch("./bar"); if (event.request.url.endsWith("foo")) return fetch("./bar");
// 3. Prevent tracker.js from being retrieved, and returns a placeholder response // 3. Prevent tracker.js from being retrieved, and returns a placeholder response
if (event.request.url.endsWith("tracker.js")) if (event.request.url.endsWith("tracker.js"))
return new Response('conosole.log("no trackers!")', { return new Response('conosole.log("no trackers!")', {
status: 200, status: 200,
headers: { "Content-Type": "text/javascript" }, headers: { "Content-Type": "text/javascript" },
}); });
// 4. Otherwise, fallthrough, perform the fetch and respond // 4. Otherwise, fallthrough, perform the fetch and respond
return fetch(event.request); return fetch(event.request);
})() })()
); );
}); });
self.addEventListener("activate", (event) => { self.addEventListener("activate", (event) => {
event.waitUntil(clients.claim()); event.waitUntil(clients.claim());
}); });
@ -1028,7 +1029,7 @@ test.describe('PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1', () => {
evt.preventDefault(); evt.preventDefault();
registration.then(r => r.update()); registration.then(r => r.update());
}); });
const registration = new Promise(r => navigator.serviceWorker.register('/worker.js').then(r)); const registration = new Promise(r => navigator.serviceWorker.register('/worker.js').then(r));
registration.then(() => updateBtn.disabled = false); registration.then(() => updateBtn.disabled = false);
</script> </script>