yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(webkit): do not fire FrameNavigated when receive resource tree (#432)

Browse Source
This commit is contained in:
Yury Semikhatsky 2020-01-08 15:32:13 -08:00 committed by GitHub
parent ff18872fda
commit b6f1b17906
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/frames.ts
View File

@ -119,9 +119,9 @@ export class FrameManager {
if (!initial) { if (!initial) {
for (const watcher of this._lifecycleWatchers) for (const watcher of this._lifecycleWatchers)
watcher._onCommittedNewDocumentNavigation(frame); watcher._onCommittedNewDocumentNavigation(frame);
}
this._page.emit(Events.Page.FrameNavigated, frame); this._page.emit(Events.Page.FrameNavigated, frame);
} }
}
frameCommittedSameDocumentNavigation(frameId: string, url: string) { frameCommittedSameDocumentNavigation(frameId: string, url: string) {
const frame = this._frames.get(frameId); const frame = this._frames.get(frameId);

2
test/evaluation.spec.js
View File

@ -97,7 +97,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROME, WEBKIT}) {
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
expect(await frameEvaluation).toBe(42); expect(await frameEvaluation).toBe(42);
}); });
it.skip(WEBKIT)('should work right after a cross-origin navigation', async({page, server}) => { it('should work right after a cross-origin navigation', async({page, server}) => {
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
let frameEvaluation = null; let frameEvaluation = null;
page.on('framenavigated', async frame => { page.on('framenavigated', async frame => {