From be5eba0cd8c8278111db15f9412cad3ecb48a313 Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Wed, 2 Sep 2020 12:56:50 -0700
Subject: [PATCH] fix(rpc): improve internal error for unexpected rpc message
 (#3734)

Sometimes I see "cannot call emit on the undefined" error on the bots.
This change adds some more logging, so we could potentially identify where
the issue comes from.
---
 src/client/connection.ts | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/src/client/connection.ts b/src/client/connection.ts
index b6604f7cb8..dd001c2d18 100644
--- a/src/client/connection.ts
+++ b/src/client/connection.ts
@@ -86,7 +86,9 @@ export class Connection {
     const { id, guid, method, params, result, error } = message as any;
     if (id) {
       debugLogger.log('channel:response', message);
-      const callback = this._callbacks.get(id)!;
+      const callback = this._callbacks.get(id);
+      if (!callback)
+        throw new Error(`Cannot find command to respond: ${id}`);
       this._callbacks.delete(id);
       if (error)
         callback.reject(parseError(error));
@@ -101,10 +103,15 @@ export class Connection {
       return;
     }
     if (method === '__dispose__') {
-      this._objects.get(guid)!._dispose();
+      const object = this._objects.get(guid);
+      if (!object)
+        throw new Error(`Cannot find object to dispose: ${guid}`);
+      object._dispose();
       return;
     }
-    const object = this._objects.get(guid)!;
+    const object = this._objects.get(guid);
+    if (!object)
+      throw new Error(`Cannot find object to call "${method}": ${guid}`);
     object._channel.emit(method, this._replaceGuidsWithChannels(params));
   }